virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Torben Hohn <torbenh@gmx.de>
Cc: xen-devel@lists.xensource.com,
	Kees Cook <kees.cook@canonical.com>,
	linux-fbdev@vger.kernel.org,
	Sascha Hauer <s.hauer@pengutronix.de>,
	James Hogan <james@albanarts.com>,
	David Airlie <airlied@linux.ie>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	James Morris <jmorris@namei.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Paul Mackerras <paulus@samba.org>,
	linux-parisc@vger.kernel.org, Magnus Damm <damm@opensource.se>,
	Jiri Slaby <jslaby@suse.cz>,
	Dan Williams <dan.j.williams@intel.com>,
	devel@driverdev.osuosl.org, Guy Martin <gmsoft@tuxicoman.be>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
	Russell King <linux@arm.linux.org.uk>,
	Thomas Gleixner <tglx@tglx.de>,
	Wu
Subject: Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()
Date: Thu, 20 Jan 2011 08:34:48 -0800	[thread overview]
Message-ID: <20110120163448.GA30588@suse.de> (raw)
In-Reply-To: <1295539104-13210-1-git-send-email-torbenh@gmx.de>

On Thu, Jan 20, 2011 at 04:58:13PM +0100, Torben Hohn wrote:
> the -rt patches change the console_semaphore to console_mutex.
> so a quite large chunk of the patches changes all
> acquire/release_console_sem() to acquire/release_console_mutex()

Why not just change the functionality of the existing function to be a
mutex in the rt patches, instead of having to rename it everywhere?

> this commit makes things use more neutral function names
> which dont make implications about the underlying lock.
> 
> the only real change is the return value of console_trylock
> which is inverted from try_acquire_console_sem()
> 
> Signed-off-by: Torben Hohn <torbenh@gmx.de>
> CC: Thomas Gleixner <tglx@tglx.de>

I don't mind this rename, but is it really going to help anything out?
What's the odds of the -rt portion of this patch ever making it to
mainline?

thanks,

greg k-h

       reply	other threads:[~2011-01-20 16:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1295539104-13210-1-git-send-email-torbenh@gmx.de>
2011-01-20 16:34 ` Greg KH [this message]
2011-01-20 16:55   ` [PATCH] change acquire/release_console_sem() to console_lock/unlock() torbenh
     [not found]   ` <20110120165502.GA10832@siel.b>
2011-01-20 20:35     ` Andrew Morton
2011-01-21  8:10       ` Geert Uytterhoeven
     [not found]       ` <AANLkTinN2+pNGk1hwrcMhH5qDNZK=Egrw7P6c-cdJTmH@mail.gmail.com>
2011-01-21  8:23         ` Andrew Morton
2011-01-20 15:58 Torben Hohn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110120163448.GA30588@suse.de \
    --to=gregkh@suse.de \
    --cc=airlied@linux.ie \
    --cc=benh@kernel.crashing.org \
    --cc=damm@opensource.se \
    --cc=dan.j.williams@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gmsoft@tuxicoman.be \
    --cc=grant.likely@secretlab.ca \
    --cc=james@albanarts.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=jmorris@namei.org \
    --cc=jslaby@suse.cz \
    --cc=kees.cook@canonical.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paulus@samba.org \
    --cc=s.hauer@pengutronix.de \
    --cc=tglx@tglx.de \
    --cc=torbenh@gmx.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).