virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: hjanssen@microsoft.com, gregkh@suse.de,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	virtualization@lists.osdl.org
Subject: Re: [PATCH 7/8] staging: hv: Convert camel cased struct fields in vmbus_packet_format.h to lower cases
Date: Wed, 26 Jan 2011 21:04:01 +0300	[thread overview]
Message-ID: <20110126180400.GS2721@bicker> (raw)
In-Reply-To: <1296064206-11372-7-git-send-email-haiyangz@microsoft.com>

On Wed, Jan 26, 2011 at 09:50:05AM -0800, Haiyang Zhang wrote:
> +	VM_PKT_INVALID				= 0x0,
> +	VM_PKT_SYNCH				= 0x1,
> +	VM_PKT_ADD_XFER_PAGESET		= 0x2,
> +	VM_PKT_RM_XFER_PAGESET		= 0x3,
                                          ^^^^
> +	VM_PKT_ESTABLISH_GPADL			= 0x4,
> +	VM_PKT_TEARDOWN_GPADL			= 0x5,
> +	VM_PKT_DATA_INBAND			= 0x6,
> +	VM_PKT_DATA_USING_XFER_PAGES		= 0x7,
> +	VM_PKT_DATA_USING_GPADL			= 0x8,
> +	VM_PKT_DATA_USING_GPA_DIRECT		= 0x9,
> +	VM_PKT_CANCEL_REQUEST			= 0xa,
> +	VM_PKT_COMP			= 0xb,
                                        ^^^^^^
> +	VM_PKT_DATA_USING_ADDITIONAL_PKT	= 0xc,
> +	VM_PKT_ADDITIONAL_DATA			= 0xd


These don't line up with the others.

regards,
dan carpenter

  parent reply	other threads:[~2011-01-26 18:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 17:49 [PATCH 1/8] staging: hv: Convert camel cased variables in connection.c to lower cases Haiyang Zhang
2011-01-26 17:50 ` [PATCH 2/8] staging: hv: Convert camel cased functions " Haiyang Zhang
2011-01-26 17:50   ` [PATCH 3/8] staging: hv: Convert camel cased variables in vmbus_drv.c " Haiyang Zhang
2011-01-26 17:50     ` [PATCH 4/8] staging: hv: Convert camel cased functions " Haiyang Zhang
2011-01-26 17:50       ` [PATCH 5/8] staging: hv: Convert camel cased struct fields in vmbus_api.h " Haiyang Zhang
2011-01-26 17:50         ` [PATCH 6/8] staging: hv: Convert camel cased struct fields in vmbus_channel_interface.h " Haiyang Zhang
2011-01-26 17:50           ` [PATCH 7/8] staging: hv: Convert camel cased struct fields in vmbus_packet_format.h " Haiyang Zhang
2011-01-26 17:50             ` [PATCH 8/8] staging: hv: Convert camel cased struct fields in vmbus_private.h " Haiyang Zhang
2011-01-26 18:04             ` Dan Carpenter [this message]
2011-01-26 20:09               ` [PATCH 7/8] staging: hv: Convert camel cased struct fields in vmbus_packet_format.h " Haiyang Zhang
2011-01-26 20:28                 ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2011-01-26 20:12 [PATCH 1/8] staging: hv: Convert camel cased variables in connection.c " Haiyang Zhang
2011-01-26 20:12 ` [PATCH 2/8] staging: hv: Convert camel cased functions " Haiyang Zhang
2011-01-26 20:12   ` [PATCH 3/8] staging: hv: Convert camel cased variables in vmbus_drv.c " Haiyang Zhang
2011-01-26 20:12     ` [PATCH 4/8] staging: hv: Convert camel cased functions " Haiyang Zhang
2011-01-26 20:12       ` [PATCH 5/8] staging: hv: Convert camel cased struct fields in vmbus_api.h " Haiyang Zhang
2011-01-26 20:12         ` [PATCH 6/8] staging: hv: Convert camel cased struct fields in vmbus_channel_interface.h " Haiyang Zhang
2011-01-26 20:12           ` [PATCH 7/8] staging: hv: Convert camel cased struct fields in vmbus_packet_format.h " Haiyang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110126180400.GS2721@bicker \
    --to=error27@gmail.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=haiyangz@microsoft.com \
    --cc=hjanssen@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).