From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH]: Staging: hv: Allocate the vmbus irq dynamically Date: Fri, 18 Feb 2011 14:07:24 -0800 Message-ID: <20110218220724.GA28986@suse.de> References: <1297799735-25917-1-git-send-email-kys@microsoft.com> <20110218211423.GH796@kroah.com> <6E21E5352C11B742B20C142EB499E048011604@TK5EX14MBXC124.redmond.corp.microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6E21E5352C11B742B20C142EB499E048011604@TK5EX14MBXC124.redmond.corp.microsoft.com> Sender: linux-kernel-owner@vger.kernel.org To: KY Srinivasan Cc: Greg KH , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" List-Id: virtualization@lists.linuxfoundation.org On Fri, Feb 18, 2011 at 10:00:04PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:greg@kroah.com] > > Sent: Friday, February 18, 2011 4:14 PM > > To: KY Srinivasan > > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; > > devel@linuxdriverproject.org; virtualization@lists.osdl.org > > Subject: Re: [PATCH]: Staging: hv: Allocate the vmbus irq dynamically > > > > On Tue, Feb 15, 2011 at 11:55:35AM -0800, K. Y. Srinivasan wrote: > > > > > > Signed-off-by: K. Y. Srinivasan > > > Signed-off-by: Haiyang Zhang > > > Signed-off-by: Hank Janssen > > > > You didn't run this through checkpatch.pl. > > > > Please do so and fix the warning it gives you. > Greg, I did run the checkpatch script against this patch and the only > complaint I got was with regards to the IRQF_SAMPLE_RANDOM flag that I > pass. As a virtual machine, this is the only external event that the > VM is going to see and so I chose to keep this flag. Is there > something that would replace this flag; looking at the Xen drivers > they do pass this flag. But that flag is going away, right? And this really can't be a valid source of entropy as the HV channel is pretty predictable. If you are only using this because Xen does/did it, that's not a valid excuse :) thanks, greg k-h