From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX Date: Wed, 23 Feb 2011 20:10:19 +0300 Message-ID: <20110223171019.GF19898@bicker> References: <1298417565-12356-1-git-send-email-hjanssen@microsoft.com> <1298436685.26511.381.camel@Joe-Laptop> <8AFC7968D54FB448A30D8F38F259C56233FAC60E@TK5EX14MBXC118.redmond.corp.microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <8AFC7968D54FB448A30D8F38F259C56233FAC60E@TK5EX14MBXC118.redmond.corp.microsoft.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devel-bounces@linuxdriverproject.org Errors-To: devel-bounces@linuxdriverproject.org To: Hank Janssen Cc: Joe Perches , "devel@linuxdriverproject.org" , "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "virtualization@lists.osdl.org" List-Id: virtualization@lists.linuxfoundation.org On Wed, Feb 23, 2011 at 04:58:10PM +0000, Hank Janssen wrote: > > Also, ff all the pr_'s are using VMBUS_MOD, > > then perhaps it would look better to add > > > > #define pr_fmt(fmt) "%s: " fmt, VMBUS_MOD > > or > > #define pr_fmt(fmt) "%s:%s " fmt, VMBUS_MOD, __func__ > > (if you must) > > I wrestled with that when I did the conversion, The reason I did not > Do that is when I check other drivers very few do it that way, most do > It the way I do it or actually hard code the module name to be printed. > And since the original objection was that DPRINT seems to implement it's > own logging I did not want to re-implement the pr_XXX calls with this layer > of indirection which almost looks like I am going down the path of DPRINT > again. > > So what is the general consensus. The current way I implemented it seems > to be how other drivers use it to. The way Joe suggested is best. regards, dan carpenter