* [PATCH] virtio console: don't manually set or finalize VIRTIO_CONSOLE_F_MULTIPORT.
@ 2011-03-09 2:55 Rusty Russell
2011-03-09 7:13 ` Amit Shah
0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2011-03-09 2:55 UTC (permalink / raw)
To: Amit Shah; +Cc: alexey.kardashevskiy, virtualization
That's already been done by the virtio infrastructure before the probe
function is called.
Reported-by: alexey.kardashevskiy@au1.ibm.com
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1680,17 +1680,12 @@ static int __devinit virtcons_probe(stru
portdev->config.max_nr_ports = 1;
if (virtio_has_feature(vdev, VIRTIO_CONSOLE_F_MULTIPORT)) {
multiport = true;
- vdev->features[0] |= 1 << VIRTIO_CONSOLE_F_MULTIPORT;
-
vdev->config->get(vdev, offsetof(struct virtio_console_config,
max_nr_ports),
&portdev->config.max_nr_ports,
sizeof(portdev->config.max_nr_ports));
}
- /* Let the Host know we support multiple ports.*/
- vdev->config->finalize_features(vdev);
-
err = init_vqs(portdev);
if (err < 0) {
dev_err(&vdev->dev, "Error %d initializing vqs\n", err);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio console: don't manually set or finalize VIRTIO_CONSOLE_F_MULTIPORT.
2011-03-09 2:55 [PATCH] virtio console: don't manually set or finalize VIRTIO_CONSOLE_F_MULTIPORT Rusty Russell
@ 2011-03-09 7:13 ` Amit Shah
0 siblings, 0 replies; 2+ messages in thread
From: Amit Shah @ 2011-03-09 7:13 UTC (permalink / raw)
To: Rusty Russell; +Cc: alexey.kardashevskiy, virtualization
On (Wed) 09 Mar 2011 [13:25:30], Rusty Russell wrote:
> That's already been done by the virtio infrastructure before the probe
> function is called.
>
> Reported-by: alexey.kardashevskiy@au1.ibm.com
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Amit Shah <amit.shah@redhat.com>
Tested-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-09 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-09 2:55 [PATCH] virtio console: don't manually set or finalize VIRTIO_CONSOLE_F_MULTIPORT Rusty Russell
2011-03-09 7:13 ` Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).