From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] xen: fix p2m section mismatches Date: Thu, 24 Mar 2011 14:48:02 -0700 Message-ID: <20110324144802.1def1400@nehalam> References: <20110324133432.544092e4.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110324133432.544092e4.randy.dunlap@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Randy Dunlap Cc: akpm , xen-devel@lists.xensource.com, Jeremy Fitzhardinge , Konrad Rzeszutek Wilk , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Thu, 24 Mar 2011 13:34:32 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > Fix section mismatch warnings: > set_phys_range_identity() is called by __init xen_set_identity(), > so also mark set_phys_range_identity() as __init. > then: > __early_alloc_p2m() is called set_phys_range_identity(), so also mark > __early_alloc_p2m() as __init. > > WARNING: arch/x86/built-in.o(.text+0x7856): Section mismatch in reference from the function __early_alloc_p2m() to the function .init.text:extend_brk() > The function __early_alloc_p2m() references > the function __init extend_brk(). > This is often because __early_alloc_p2m lacks a __init > annotation or the annotation of extend_brk is wrong. > > WARNING: arch/x86/built-in.o(.text+0x7967): Section mismatch in reference from the function set_phys_range_identity() to the function .init.text:extend_brk() > The function set_phys_range_identity() references > the function __init extend_brk(). > This is often because set_phys_range_identity lacks a __init > annotation or the annotation of extend_brk is wrong. > > Signed-off-by: Randy Dunlap > --- > arch/x86/xen/p2m.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-2.6.38-git13.orig/arch/x86/xen/p2m.c > +++ linux-2.6.38-git13/arch/x86/xen/p2m.c > @@ -497,7 +497,7 @@ static bool alloc_p2m(unsigned long pfn) > return true; > } > > -bool __early_alloc_p2m(unsigned long pfn) > +bool __init __early_alloc_p2m(unsigned long pfn) __early_alloc_p2m could be static as well. --