From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Ian.Campbell@citrix.com, virtualization@lists.linux-foundation.org
Cc: jeremy.fitzhardinge@citrix.com, konrad.wilk@oracle.com
Subject: Signed bit field; int have_hotplug_status_watch:1
Date: Sun, 3 Apr 2011 22:32:41 +0100 [thread overview]
Message-ID: <20110403213241.GA25913@gallifrey> (raw)
Hi Ian,
I've been going through some sparse scans of the kernel and
it threw up:
CHECK drivers/net/xen-netback/xenbus.c
drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield
int have_hotplug_status_watch:1;
from your patch f942dc2552b8bfdee607be867b12a8971bb9cd85
It does look like that should be an unsigned (given it's assigned
0 and 1)
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next reply other threads:[~2011-04-03 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 21:32 Dr. David Alan Gilbert [this message]
2011-04-04 8:26 ` Signed bit field; int have_hotplug_status_watch:1 Ian Campbell
[not found] ` <1301905584.23887.49.camel@zakaz.uk.xensource.com>
2011-04-06 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403213241.GA25913@gallifrey \
--to=linux@treblig.org \
--cc=Ian.Campbell@citrix.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox