From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig Date: Wed, 4 May 2011 12:33:02 -0700 Message-ID: <20110504123302.1ef22682.rdunlap@xenotime.net> References: <1304535105-26892-1-git-send-email-kys@microsoft.com> <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net> <20110504185338.GB9823@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110504185338.GB9823@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Greg KH Cc: "virtualization@lists.osdl.org" , "devel@linuxdriverproject.org" , H Hartley Sweeten , Haiyang Zhang , "linux-kernel@vger.kernel.org" List-Id: virtualization@lists.linuxfoundation.org On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote: > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote: > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote: > > > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change > > > Kconfig to reflect this. > > > > > > Signed-off-by: K. Y. Srinivasan > > > Signed-off-by: Haiyang Zhang > > > --- > > > drivers/staging/hv/Kconfig | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig > > > index 76f0756..5e0c9f6 100644 > > > --- a/drivers/staging/hv/Kconfig > > > +++ b/drivers/staging/hv/Kconfig > > > @@ -1,6 +1,6 @@ > > > config HYPERV > > > tristate "Microsoft Hyper-V client drivers" > > > - depends on X86 && m > > > + depends on X86 && ACPI && PCI && m > > > default n > > > help > > > Select this option to run Linux as a Hyper-V client operating > > > > ACPI itself depends on PCI. > > Still? I thought that got removed a while ago. Still. Len has written in the past that technically there is no such dependency, but in reality there is, for now at least. IIRC. > > It also depends on IA64 || X86. Will the vmbus driver work with IA64? > > No. > > > If so the depends on could just be: > > > > depends on ACPI && m > > No, see above for the IA64 reason. > > > Also, default n is redudant since n is the default anyway. > > True, but it doesn't hurt either :) --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***