* [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
@ 2011-05-04 18:51 K. Y. Srinivasan
2011-05-04 18:44 ` H Hartley Sweeten
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: K. Y. Srinivasan @ 2011-05-04 18:51 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, virtualization
Cc: K. Y. Srinivasan, Haiyang Zhang
The vmbus driver dependes on ACPI and PCI subsystems. Change
Kconfig to reflect this.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/staging/hv/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
index 76f0756..5e0c9f6 100644
--- a/drivers/staging/hv/Kconfig
+++ b/drivers/staging/hv/Kconfig
@@ -1,6 +1,6 @@
config HYPERV
tristate "Microsoft Hyper-V client drivers"
- depends on X86 && m
+ depends on X86 && ACPI && PCI && m
default n
help
Select this option to run Linux as a Hyper-V client operating
--
1.7.4.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 18:51 [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig K. Y. Srinivasan
@ 2011-05-04 18:44 ` H Hartley Sweeten
2011-05-04 18:51 ` Christoph Hellwig
[not found] ` <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net>
2 siblings, 0 replies; 12+ messages in thread
From: H Hartley Sweeten @ 2011-05-04 18:44 UTC (permalink / raw)
To: K. Y. Srinivasan, gregkh@suse.de, linux-kernel@vger.kernel.org
Cc: Haiyang Zhang
On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
>
> The vmbus driver dependes on ACPI and PCI subsystems. Change
> Kconfig to reflect this.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
> drivers/staging/hv/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> index 76f0756..5e0c9f6 100644
> --- a/drivers/staging/hv/Kconfig
> +++ b/drivers/staging/hv/Kconfig
> @@ -1,6 +1,6 @@
> config HYPERV
> tristate "Microsoft Hyper-V client drivers"
> - depends on X86 && m
> + depends on X86 && ACPI && PCI && m
> default n
> help
> Select this option to run Linux as a Hyper-V client operating
ACPI itself depends on PCI. It also depends on IA64 || X86. Will the
vmbus driver work with IA64? If so the depends on could just be:
depends on ACPI && m
Also, default n is redudant since n is the default anyway.
Regards,
Hartley
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 18:51 [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig K. Y. Srinivasan
2011-05-04 18:44 ` H Hartley Sweeten
@ 2011-05-04 18:51 ` Christoph Hellwig
2011-05-04 18:59 ` Greg KH
[not found] ` <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net>
2 siblings, 1 reply; 12+ messages in thread
From: Christoph Hellwig @ 2011-05-04 18:51 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: gregkh, linux-kernel, devel, virtualization, Haiyang Zhang
On Wed, May 04, 2011 at 11:51:45AM -0700, K. Y. Srinivasan wrote:
> config HYPERV
> tristate "Microsoft Hyper-V client drivers"
> - depends on X86 && m
> + depends on X86 && ACPI && PCI && m
I can't see anything preventing this driver from beeing built-in,
so the "depends on m" should probably go away.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 18:51 ` Christoph Hellwig
@ 2011-05-04 18:59 ` Greg KH
0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2011-05-04 18:59 UTC (permalink / raw)
To: Christoph Hellwig
Cc: K. Y. Srinivasan, linux-kernel, devel, virtualization,
Haiyang Zhang
On Wed, May 04, 2011 at 02:51:42PM -0400, Christoph Hellwig wrote:
> On Wed, May 04, 2011 at 11:51:45AM -0700, K. Y. Srinivasan wrote:
> > config HYPERV
> > tristate "Microsoft Hyper-V client drivers"
> > - depends on X86 && m
> > + depends on X86 && ACPI && PCI && m
>
> I can't see anything preventing this driver from beeing built-in,
> so the "depends on m" should probably go away.
Originally there were some problems with some bad global symbols.
Hopefully those should all be resolved now, but it can't hurt to review
the code to verify this first.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net>]
* RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
[not found] ` <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net>
@ 2011-05-04 18:48 ` KY Srinivasan
2011-05-04 18:53 ` Greg KH
1 sibling, 0 replies; 12+ messages in thread
From: KY Srinivasan @ 2011-05-04 18:48 UTC (permalink / raw)
To: H Hartley Sweeten, gregkh@suse.de, linux-kernel@vger.kernel.org,
devel
Cc: Haiyang Zhang
> -----Original Message-----
> From: H Hartley Sweeten [mailto:hartleys@visionengravers.com]
> Sent: Wednesday, May 04, 2011 2:44 PM
> To: KY Srinivasan; gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Cc: Haiyang Zhang
> Subject: RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> Kconfig
>
> On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> >
> > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > Kconfig to reflect this.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > ---
> > drivers/staging/hv/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > index 76f0756..5e0c9f6 100644
> > --- a/drivers/staging/hv/Kconfig
> > +++ b/drivers/staging/hv/Kconfig
> > @@ -1,6 +1,6 @@
> > config HYPERV
> > tristate "Microsoft Hyper-V client drivers"
> > - depends on X86 && m
> > + depends on X86 && ACPI && PCI && m
> > default n
> > help
> > Select this option to run Linux as a Hyper-V client operating
>
> ACPI itself depends on PCI. It also depends on IA64 || X86. Will the
> vmbus driver work with IA64? If so the depends on could just be:
>
> depends on ACPI && m
Good point; vmbus will not work on IA64 though. So, minimally we would want
X86 && ACPI. I will resend this with this change.
Regards,
K. Y
>
> Also, default n is redudant since n is the default anyway.
>
> Regards,
> Hartley
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
[not found] ` <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net>
2011-05-04 18:48 ` KY Srinivasan
@ 2011-05-04 18:53 ` Greg KH
2011-05-04 19:33 ` Randy Dunlap
1 sibling, 1 reply; 12+ messages in thread
From: Greg KH @ 2011-05-04 18:53 UTC (permalink / raw)
To: H Hartley Sweeten
Cc: devel@linuxdriverproject.org, Haiyang Zhang,
linux-kernel@vger.kernel.org, virtualization@lists.osdl.org
On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> >
> > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > Kconfig to reflect this.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > ---
> > drivers/staging/hv/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > index 76f0756..5e0c9f6 100644
> > --- a/drivers/staging/hv/Kconfig
> > +++ b/drivers/staging/hv/Kconfig
> > @@ -1,6 +1,6 @@
> > config HYPERV
> > tristate "Microsoft Hyper-V client drivers"
> > - depends on X86 && m
> > + depends on X86 && ACPI && PCI && m
> > default n
> > help
> > Select this option to run Linux as a Hyper-V client operating
>
> ACPI itself depends on PCI.
Still? I thought that got removed a while ago.
> It also depends on IA64 || X86. Will the vmbus driver work with IA64?
No.
> If so the depends on could just be:
>
> depends on ACPI && m
No, see above for the IA64 reason.
> Also, default n is redudant since n is the default anyway.
True, but it doesn't hurt either :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 18:53 ` Greg KH
@ 2011-05-04 19:33 ` Randy Dunlap
2011-05-04 19:39 ` Greg KH
0 siblings, 1 reply; 12+ messages in thread
From: Randy Dunlap @ 2011-05-04 19:33 UTC (permalink / raw)
To: Greg KH
Cc: virtualization@lists.osdl.org, devel@linuxdriverproject.org,
H Hartley Sweeten, Haiyang Zhang, linux-kernel@vger.kernel.org
On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > >
> > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > Kconfig to reflect this.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > ---
> > > drivers/staging/hv/Kconfig | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > index 76f0756..5e0c9f6 100644
> > > --- a/drivers/staging/hv/Kconfig
> > > +++ b/drivers/staging/hv/Kconfig
> > > @@ -1,6 +1,6 @@
> > > config HYPERV
> > > tristate "Microsoft Hyper-V client drivers"
> > > - depends on X86 && m
> > > + depends on X86 && ACPI && PCI && m
> > > default n
> > > help
> > > Select this option to run Linux as a Hyper-V client operating
> >
> > ACPI itself depends on PCI.
>
> Still? I thought that got removed a while ago.
Still. Len has written in the past that technically there is no such
dependency, but in reality there is, for now at least. IIRC.
> > It also depends on IA64 || X86. Will the vmbus driver work with IA64?
>
> No.
>
> > If so the depends on could just be:
> >
> > depends on ACPI && m
>
> No, see above for the IA64 reason.
>
> > Also, default n is redudant since n is the default anyway.
>
> True, but it doesn't hurt either :)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 19:33 ` Randy Dunlap
@ 2011-05-04 19:39 ` Greg KH
2011-05-04 19:54 ` KY Srinivasan
2011-05-04 19:55 ` Randy Dunlap
0 siblings, 2 replies; 12+ messages in thread
From: Greg KH @ 2011-05-04 19:39 UTC (permalink / raw)
To: Randy Dunlap
Cc: H Hartley Sweeten, devel@linuxdriverproject.org, Haiyang Zhang,
linux-kernel@vger.kernel.org, virtualization@lists.osdl.org
On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
>
> > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > >
> > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > Kconfig to reflect this.
> > > >
> > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > > ---
> > > > drivers/staging/hv/Kconfig | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > index 76f0756..5e0c9f6 100644
> > > > --- a/drivers/staging/hv/Kconfig
> > > > +++ b/drivers/staging/hv/Kconfig
> > > > @@ -1,6 +1,6 @@
> > > > config HYPERV
> > > > tristate "Microsoft Hyper-V client drivers"
> > > > - depends on X86 && m
> > > > + depends on X86 && ACPI && PCI && m
> > > > default n
> > > > help
> > > > Select this option to run Linux as a Hyper-V client operating
> > >
> > > ACPI itself depends on PCI.
> >
> > Still? I thought that got removed a while ago.
>
> Still. Len has written in the past that technically there is no such
> dependency, but in reality there is, for now at least. IIRC.
Ok, but then we should still say we depend on PCI to handle if/when ACPI
removes that dependancy in the future. It doesn't hurt here at all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 19:39 ` Greg KH
@ 2011-05-04 19:54 ` KY Srinivasan
2011-05-04 19:58 ` Greg KH
2011-05-04 19:55 ` Randy Dunlap
1 sibling, 1 reply; 12+ messages in thread
From: KY Srinivasan @ 2011-05-04 19:54 UTC (permalink / raw)
To: Greg KH, Randy Dunlap
Cc: virtualization@lists.osdl.org, devel@linuxdriverproject.org,
H Hartley Sweeten, Haiyang Zhang, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: devel-bounces@linuxdriverproject.org [mailto:devel-
> bounces@linuxdriverproject.org] On Behalf Of Greg KH
> Sent: Wednesday, May 04, 2011 3:40 PM
> To: Randy Dunlap
> Cc: virtualization@lists.osdl.org; devel@linuxdriverproject.org; H Hartley
> Sweeten; Haiyang Zhang; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> Kconfig
>
> On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> >
> > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > > >
> > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > > Kconfig to reflect this.
> > > > >
> > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > > > ---
> > > > > drivers/staging/hv/Kconfig | 2 +-
> > > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > > >
> > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > > index 76f0756..5e0c9f6 100644
> > > > > --- a/drivers/staging/hv/Kconfig
> > > > > +++ b/drivers/staging/hv/Kconfig
> > > > > @@ -1,6 +1,6 @@
> > > > > config HYPERV
> > > > > tristate "Microsoft Hyper-V client drivers"
> > > > > - depends on X86 && m
> > > > > + depends on X86 && ACPI && PCI && m
> > > > > default n
> > > > > help
> > > > > Select this option to run Linux as a Hyper-V client operating
> > > >
> > > > ACPI itself depends on PCI.
> > >
> > > Still? I thought that got removed a while ago.
> >
> > Still. Len has written in the past that technically there is no such
> > dependency, but in reality there is, for now at least. IIRC.
>
> Ok, but then we should still say we depend on PCI to handle if/when ACPI
> removes that dependancy in the future. It doesn't hurt here at all.
Greg,
I have sent you both versions of this patch; one with explicit dependency on PCI and
one with implicit dependency on PCI; you decide.
Regards,
K. Y
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 19:54 ` KY Srinivasan
@ 2011-05-04 19:58 ` Greg KH
0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2011-05-04 19:58 UTC (permalink / raw)
To: KY Srinivasan
Cc: Randy Dunlap, virtualization@lists.osdl.org,
devel@linuxdriverproject.org, H Hartley Sweeten, Haiyang Zhang,
linux-kernel@vger.kernel.org
On Wed, May 04, 2011 at 07:54:09PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: devel-bounces@linuxdriverproject.org [mailto:devel-
> > bounces@linuxdriverproject.org] On Behalf Of Greg KH
> > Sent: Wednesday, May 04, 2011 3:40 PM
> > To: Randy Dunlap
> > Cc: virtualization@lists.osdl.org; devel@linuxdriverproject.org; H Hartley
> > Sweeten; Haiyang Zhang; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> > Kconfig
> >
> > On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> > > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> > >
> > > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > > > >
> > > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > > > Kconfig to reflect this.
> > > > > >
> > > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > > > > ---
> > > > > > drivers/staging/hv/Kconfig | 2 +-
> > > > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > > > index 76f0756..5e0c9f6 100644
> > > > > > --- a/drivers/staging/hv/Kconfig
> > > > > > +++ b/drivers/staging/hv/Kconfig
> > > > > > @@ -1,6 +1,6 @@
> > > > > > config HYPERV
> > > > > > tristate "Microsoft Hyper-V client drivers"
> > > > > > - depends on X86 && m
> > > > > > + depends on X86 && ACPI && PCI && m
> > > > > > default n
> > > > > > help
> > > > > > Select this option to run Linux as a Hyper-V client operating
> > > > >
> > > > > ACPI itself depends on PCI.
> > > >
> > > > Still? I thought that got removed a while ago.
> > >
> > > Still. Len has written in the past that technically there is no such
> > > dependency, but in reality there is, for now at least. IIRC.
> >
> > Ok, but then we should still say we depend on PCI to handle if/when ACPI
> > removes that dependancy in the future. It doesn't hurt here at all.
>
> Greg,
> I have sent you both versions of this patch; one with explicit dependency on PCI and
> one with implicit dependency on PCI; you decide.
Thanks, I'll pick one :)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
2011-05-04 19:39 ` Greg KH
2011-05-04 19:54 ` KY Srinivasan
@ 2011-05-04 19:55 ` Randy Dunlap
1 sibling, 0 replies; 12+ messages in thread
From: Randy Dunlap @ 2011-05-04 19:55 UTC (permalink / raw)
To: Greg KH
Cc: H Hartley Sweeten, devel@linuxdriverproject.org, Haiyang Zhang,
linux-kernel@vger.kernel.org, virtualization@lists.osdl.org
On Wed, 4 May 2011 12:39:54 -0700 Greg KH wrote:
> On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> >
> > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > > >
> > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > > Kconfig to reflect this.
> > > > >
> > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > > > ---
> > > > > drivers/staging/hv/Kconfig | 2 +-
> > > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > > >
> > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > > index 76f0756..5e0c9f6 100644
> > > > > --- a/drivers/staging/hv/Kconfig
> > > > > +++ b/drivers/staging/hv/Kconfig
> > > > > @@ -1,6 +1,6 @@
> > > > > config HYPERV
> > > > > tristate "Microsoft Hyper-V client drivers"
> > > > > - depends on X86 && m
> > > > > + depends on X86 && ACPI && PCI && m
> > > > > default n
> > > > > help
> > > > > Select this option to run Linux as a Hyper-V client operating
> > > >
> > > > ACPI itself depends on PCI.
> > >
> > > Still? I thought that got removed a while ago.
> >
> > Still. Len has written in the past that technically there is no such
> > dependency, but in reality there is, for now at least. IIRC.
>
> Ok, but then we should still say we depend on PCI to handle if/when ACPI
> removes that dependancy in the future. It doesn't hurt here at all.
Yes, I prefer that also.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
@ 2011-05-04 19:19 K. Y. Srinivasan
0 siblings, 0 replies; 12+ messages in thread
From: K. Y. Srinivasan @ 2011-05-04 19:19 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, virtualization
Cc: K. Y. Srinivasan, Haiyang Zhang
The vmbus driver dependes on ACPI and PCI subsystems. Change
Kconfig to reflect this.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/staging/hv/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
index 76f0756..d8c119c 100644
--- a/drivers/staging/hv/Kconfig
+++ b/drivers/staging/hv/Kconfig
@@ -1,6 +1,6 @@
config HYPERV
tristate "Microsoft Hyper-V client drivers"
- depends on X86 && m
+ depends on X86 && ACPI && m
default n
help
Select this option to run Linux as a Hyper-V client operating
--
1.7.4.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-05-04 19:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-04 18:51 [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig K. Y. Srinivasan
2011-05-04 18:44 ` H Hartley Sweeten
2011-05-04 18:51 ` Christoph Hellwig
2011-05-04 18:59 ` Greg KH
[not found] ` <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net>
2011-05-04 18:48 ` KY Srinivasan
2011-05-04 18:53 ` Greg KH
2011-05-04 19:33 ` Randy Dunlap
2011-05-04 19:39 ` Greg KH
2011-05-04 19:54 ` KY Srinivasan
2011-05-04 19:58 ` Greg KH
2011-05-04 19:55 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2011-05-04 19:19 K. Y. Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).