From: Christoph Hellwig <hch@infradead.org>
To: KY Srinivasan <kys@microsoft.com>
Cc: "virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>
Subject: Re: various vmbus review comments
Date: Mon, 9 May 2011 10:33:52 -0400 [thread overview]
Message-ID: <20110509143352.GB29635@infradead.org> (raw)
In-Reply-To: <6E21E5352C11B742B20C142EB499E0481E0694@TK5EX14MBXC124.redmond.corp.microsoft.com>
On Fri, May 06, 2011 at 01:10:38PM +0000, KY Srinivasan wrote:
> I audited the block and the net drivers. As part of their exit routine,
> they invoke vmbus_child_driver_unregister() after properly cleaning
> up all the devices they are managing. Do you still see an issue with
> regards to module reference counting.
Which is not the correct thing to do as explained in my last round
of reviews. Take a look at the PCI code - the functional driver only
does a foo_untegister_driver (which maps almost directly to
driver_unregister), which then causes the device core to unbind the
devices. The function driver must never call device_unregister
directly as the device continues to exist even if no driver is bound to
it.
next prev parent reply other threads:[~2011-05-09 14:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 20:46 various vmbus review comments Greg KH
2011-05-03 21:00 ` KY Srinivasan
2011-05-03 22:03 ` Greg KH
2011-05-03 22:49 ` KY Srinivasan
2011-05-04 16:20 ` KY Srinivasan
2011-05-04 16:32 ` Greg KH
2011-05-04 16:58 ` KY Srinivasan
2011-05-04 18:28 ` Greg KH
2011-05-06 13:10 ` KY Srinivasan
2011-05-06 14:59 ` Greg KH
2011-05-06 17:34 ` KY Srinivasan
2011-05-09 14:33 ` Christoph Hellwig [this message]
2011-05-09 14:56 ` KY Srinivasan
2011-05-10 5:24 ` Christoph Hellwig
2011-05-10 13:00 ` KY Srinivasan
2011-05-10 13:07 ` Christoph Hellwig
2011-05-10 13:16 ` Greg KH
2011-05-09 1:46 ` KY Srinivasan
2011-05-09 3:04 ` Greg KH
2011-05-09 12:35 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509143352.GB29635@infradead.org \
--to=hch@infradead.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).