vmbus driver

vmbus driver

[K. Y. Srinivasan]

 
Greg,

A few days ago you applied all the outstanding patches for the Hyper-V
drivers. With these patches, I have addressed all of the known review 
comments for the  vmbus driver (and a lot of comments/issues in other
drivers as well). I am still hoping I can address 
whatever other issues/comments there might be with the intention to 
get the vmbus driver out of staging in the current window. What is your 
sense in terms of how feasible this is. From my side, I can assure you 
that I will address all legitimate issues in a very timely manner and this
will not be dependent upon the location of the drivers (staging or 
outside staging). Looking forward to hearing from you.

Regards,

K. Y

Re: vmbus driver

[Christoph Hellwig]

On Thu, May 19, 2011 at 03:06:25PM -0700, K. Y. Srinivasan wrote:
> A few days ago you applied all the outstanding patches for the Hyper-V
> drivers. With these patches, I have addressed all of the known review 
> comments for the  vmbus driver (and a lot of comments/issues in other
> drivers as well). I am still hoping I can address 
> whatever other issues/comments there might be with the intention to 
> get the vmbus driver out of staging in the current window. What is your 
> sense in terms of how feasible this is. From my side, I can assure you 
> that I will address all legitimate issues in a very timely manner and this
> will not be dependent upon the location of the drivers (staging or 
> outside staging). Looking forward to hearing from you.

There's no point in merging it without a user.  Make sure either
the network or storage driver is in a good enough shape to move with it,
to make sure the APIs it exports are actually sanely usable.

On the other hand the HV clocksource looks mostly mergeable and doesn't
depend on vmbus.  Send a patch to add it to drivers/clocksource to the
maintainer and it should be mergeable with very little remaining
cleanup.

RE: vmbus driver

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Friday, May 20, 2011 8:27 AM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Subject: Re: vmbus driver
> 
> On Thu, May 19, 2011 at 03:06:25PM -0700, K. Y. Srinivasan wrote:
> > A few days ago you applied all the outstanding patches for the Hyper-V
> > drivers. With these patches, I have addressed all of the known review
> > comments for the  vmbus driver (and a lot of comments/issues in other
> > drivers as well). I am still hoping I can address
> > whatever other issues/comments there might be with the intention to
> > get the vmbus driver out of staging in the current window. What is your
> > sense in terms of how feasible this is. From my side, I can assure you
> > that I will address all legitimate issues in a very timely manner and this
> > will not be dependent upon the location of the drivers (staging or
> > outside staging). Looking forward to hearing from you.
> 
> There's no point in merging it without a user.  Make sure either
> the network or storage driver is in a good enough shape to move with it,
> to make sure the APIs it exports are actually sanely usable.

Well, the util driver that implements a range of other services such as KVP, 
time synch, heartbeat etc. is also a client of the vmbus driver (perhaps not in the 
same way as the storage and network drivers). I  was hoping  to
move the util driver out of staging along with the vmbus driver.

On a different note, thanks to the feedback I got from you, Greg and others,
both storage and network drivers are in a much better shape than they ever were.
I will continue to cleanup the storage drivers and I would greatly appreciate your 
feedback and review. 

> 
> On the other hand the HV clocksource looks mostly mergeable and doesn't
> depend on vmbus.  Send a patch to add it to drivers/clocksource to the
> maintainer and it should be mergeable with very little remaining
> cleanup.

Agreed, now that the merge window is closed, I will have to wait for a few weeks.

Regards,

K. Y
 

Re: vmbus driver

[Christoph Hellwig]

On Fri, May 20, 2011 at 01:12:32PM +0000, KY Srinivasan wrote:
> Well, the util driver that implements a range of other services such as KVP, 
> time synch, heartbeat etc. is also a client of the vmbus driver (perhaps not in the 

The KVP driver is a different module as far as I can see.  But it really
needs a lot of work, as no one should use the ugly connector interface
for new code.  The closest equivalent is gennetlink, but I'd like to
understand what it's actually supposed to do in practice.

RE: vmbus driver

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Friday, May 20, 2011 9:22 AM
> To: KY Srinivasan
> Cc: Christoph Hellwig; gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Subject: Re: vmbus driver
> 
> On Fri, May 20, 2011 at 01:12:32PM +0000, KY Srinivasan wrote:
> > Well, the util driver that implements a range of other services such as KVP,
> > time synch, heartbeat etc. is also a client of the vmbus driver (perhaps not in
> the
> 
> The KVP driver is a different module as far as I can see.  But it really
> needs a lot of work, as no one should use the ugly connector interface
> for new code.  The closest equivalent is gennetlink, but I'd like to
> understand what it's actually supposed to do in practice.

Chris,

I wrote the KVP component of the util driver less than a year ago and 
This code was reviewed on this list before it was accepted. The KVP (Key Value Pair)
functionality supports host based queries on the guest. The data gathering in
the guest is done in user-mode and the kernel component of KVP is used to
communicate with the host. I am using the connector interface to support
communication between the kernel component and the user-mode daemon.
The KVP functionality is needed to integrate with the Microsoft management 
stack on the host.

Regards,

K. Y 
 

RE: vmbus driver

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Friday, May 20, 2011 8:27 AM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Subject: Re: vmbus driver
> 
> On Thu, May 19, 2011 at 03:06:25PM -0700, K. Y. Srinivasan wrote:
> > A few days ago you applied all the outstanding patches for the Hyper-V
> > drivers. With these patches, I have addressed all of the known review
> > comments for the  vmbus driver (and a lot of comments/issues in other
> > drivers as well). I am still hoping I can address
> > whatever other issues/comments there might be with the intention to
> > get the vmbus driver out of staging in the current window. What is your
> > sense in terms of how feasible this is. From my side, I can assure you
> > that I will address all legitimate issues in a very timely manner and this
> > will not be dependent upon the location of the drivers (staging or
> > outside staging). Looking forward to hearing from you.
> 
> There's no point in merging it without a user.  Make sure either
> the network or storage driver is in a good enough shape to move with it,
> to make sure the APIs it exports are actually sanely usable.
> 
> On the other hand the HV clocksource looks mostly mergeable and doesn't
> depend on vmbus.  Send a patch to add it to drivers/clocksource to the
> maintainer and it should be mergeable with very little remaining
> cleanup.

I see maintainers for each of the clocksource drivers and I see John Stultz and
Thomas  Gleixner listed as the maintainers for Timekeeping. Who should sign-off
on the Hyper-V clocksource.

Regards,

K. Y

Re: vmbus driver

[Christoph Hellwig]

> I see maintainers for each of the clocksource drivers and I see John Stultz and
> Thomas  Gleixner listed as the maintainers for Timekeeping. Who should sign-off
> on the Hyper-V clocksource.

just send it to both of the with linux-kernel in Cc, and either of them
will probably put it in.

RE: vmbus driver

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Sunday, May 22, 2011 7:00 AM
> To: KY Srinivasan
> Cc: Christoph Hellwig; gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Subject: Re: vmbus driver
> 
> > I see maintainers for each of the clocksource drivers and I see John Stultz and
> > Thomas  Gleixner listed as the maintainers for Timekeeping. Who should sign-
> off
> > on the Hyper-V clocksource.
> 
> just send it to both of the with linux-kernel in Cc, and either of them
> will probably put it in.
> 
Will do.

Thanks,

K. Y

RE: vmbus driver

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Sunday, May 22, 2011 7:00 AM
> To: KY Srinivasan
> Cc: Christoph Hellwig; gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Subject: Re: vmbus driver
> 
> > I see maintainers for each of the clocksource drivers and I see John Stultz and
> > Thomas  Gleixner listed as the maintainers for Timekeeping. Who should sign-
> off
> > on the Hyper-V clocksource.
> 
> just send it to both of the with linux-kernel in Cc, and either of them
> will probably put it in.
> 

John, Thomas,

I am working on getting Hyper-V drivers (drivers/staging/hv/*) out of staging.
I would like to request you to look at the Hyper-V timesource driver:
drivers/staging/hv/hv_timesource.c. The supporting code for this driver
is already part of the base kernel. Let me know if this driver is ready to exit staging.

Regards,

K. Y

RE: vmbus driver

[Thomas Gleixner]

On Mon, 23 May 2011, KY Srinivasan wrote:
> I am working on getting Hyper-V drivers (drivers/staging/hv/*) out of staging.
> I would like to request you to look at the Hyper-V timesource driver:
> drivers/staging/hv/hv_timesource.c. The supporting code for this driver
> is already part of the base kernel. Let me know if this driver is ready to exit staging.

Can you please send a patch against drivers/clocksource (the staging
part is uninteresting for review).

Thanks,

	tglx

RE: vmbus driver

[KY Srinivasan]

> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@linutronix.de]
> Sent: Monday, May 23, 2011 9:52 AM
> To: KY Srinivasan
> Cc: Christoph Hellwig; johnstul@us.ibm.com; gregkh@suse.de; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org;
> virtualization@lists.osdl.org
> Subject: RE: vmbus driver
> 
> On Mon, 23 May 2011, KY Srinivasan wrote:
> > I am working on getting Hyper-V drivers (drivers/staging/hv/*) out of staging.
> > I would like to request you to look at the Hyper-V timesource driver:
> > drivers/staging/hv/hv_timesource.c. The supporting code for this driver
> > is already part of the base kernel. Let me know if this driver is ready to exit
> staging.
> 
> Can you please send a patch against drivers/clocksource (the staging
> part is uninteresting for review).

Will do.

Regards,

K. Y

Re: vmbus driver

[Greg KH]

On Thu, May 19, 2011 at 03:06:25PM -0700, K. Y. Srinivasan wrote:
>  
> Greg,
> 
> A few days ago you applied all the outstanding patches for the Hyper-V
> drivers. With these patches, I have addressed all of the known review 
> comments for the  vmbus driver (and a lot of comments/issues in other
> drivers as well). I am still hoping I can address 
> whatever other issues/comments there might be with the intention to 
> get the vmbus driver out of staging in the current window. What is your 
> sense in terms of how feasible this is. From my side, I can assure you 
> that I will address all legitimate issues in a very timely manner and this
> will not be dependent upon the location of the drivers (staging or 
> outside staging). Looking forward to hearing from you.

The merge window is closed now, and I'm on the road in asia for about 3
weeks, so doing this, at this point in the development cycle, is going
to be hard.

I'll go review the bus code again after the code is all merged with
Linus, which should take a week or so depending on my schedule, and let
you know what's left to do (I think there still is something wierd with
the way the hv_driver is structured, but I could be wrong.)

In the mean time, I'm sure the block and network driver still need a lot
of work, and merging the bus code doesn't make much sense without them
as a user as that is what people really want to use, so you can continue
to work on them.

thanks,

greg k-h

RE: vmbus driver

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Friday, May 20, 2011 9:05 AM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Subject: Re: vmbus driver
> 
> On Thu, May 19, 2011 at 03:06:25PM -0700, K. Y. Srinivasan wrote:
> >
> > Greg,
> >
> > A few days ago you applied all the outstanding patches for the Hyper-V
> > drivers. With these patches, I have addressed all of the known review
> > comments for the  vmbus driver (and a lot of comments/issues in other
> > drivers as well). I am still hoping I can address
> > whatever other issues/comments there might be with the intention to
> > get the vmbus driver out of staging in the current window. What is your
> > sense in terms of how feasible this is. From my side, I can assure you
> > that I will address all legitimate issues in a very timely manner and this
> > will not be dependent upon the location of the drivers (staging or
> > outside staging). Looking forward to hearing from you.
> 
> The merge window is closed now, and I'm on the road in asia for about 3
> weeks, so doing this, at this point in the development cycle, is going
> to be hard.
> 
> I'll go review the bus code again after the code is all merged with
> Linus, which should take a week or so depending on my schedule, and let
> you know what's left to do (I think there still is something wierd with
> the way the hv_driver is structured, but I could be wrong.)

Thanks Greg. I look forward to your feedback.

> 
> In the mean time, I'm sure the block and network driver still need a lot
> of work, and merging the bus code doesn't make much sense without them
> as a user as that is what people really want to use, so you can continue
> to work on them.

I will continue to cleanup the block and network driver code. As you know the
util driver is also a client of the vmbus driver (as far as the communication with 
the host goes). So, it may still make sense to plan for getting the vmbus driver out 
of staging along with the util and the timesource driver. 

Regards,

K. Y