From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper - vmbus_onchannel_event() Date: Mon, 6 Jun 2011 19:15:11 -0400 Message-ID: <20110606231511.GB18222@infradead.org> References: <1307400540-13193-1-git-send-email-kys@microsoft.com> <1307400613-13234-1-git-send-email-kys@microsoft.com> <1307400613-13234-24-git-send-email-kys@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1307400613-13234-24-git-send-email-kys@microsoft.com> Sender: linux-kernel-owner@vger.kernel.org To: "K. Y. Srinivasan" Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, Haiyang Zhang , Abhishek Kane List-Id: virtualization@lists.linuxfoundation.org On Mon, Jun 06, 2011 at 03:49:48PM -0700, K. Y. Srinivasan wrote: > Now, get rid of the unused wrapper - vmbus_onchannel_event(). I'd merge this into the previous patch. In general your patch split seem a little too fine grained to me in general. When you remove a wrapper you can inline it into the callsite directly, if you clean up a function directly inlining it into the helper is fine, etc.