From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 34/40] Staging: hv: storvsc: Add the contents of hyperv_storage.h to storvsc_drv.c Date: Fri, 1 Jul 2011 04:16:01 -0400 Message-ID: <20110701081601.GB28322@infradead.org> References: <1309358301-8488-1-git-send-email-kys@microsoft.com> <1309358377-8537-1-git-send-email-kys@microsoft.com> <1309358377-8537-34-git-send-email-kys@microsoft.com> <20110630194530.GE22707@infradead.org> <6E21E5352C11B742B20C142EB499E0480816C297@TK5EX14MBXC126.redmond.corp.microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6E21E5352C11B742B20C142EB499E0480816C297@TK5EX14MBXC126.redmond.corp.microsoft.com> Sender: linux-kernel-owner@vger.kernel.org To: KY Srinivasan Cc: Christoph Hellwig , "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" , Haiyang Zhang , "Abhishek Kane (Mindtree Consulting PVT LTD)" , Hank Janssen List-Id: virtualization@lists.linuxfoundation.org On Thu, Jun 30, 2011 at 08:13:51PM +0000, KY Srinivasan wrote: > > > Add the contents of hyperv_storage.h to storvsc_drv.c and cleanup > > storvsc_drv.c.n > > > > I'd at least leave the first half of the header that defines the > > protocol around. > > I only got rid of the block comment at the start of hyperv_storage.h > and consolidated the include files. Nothing of substance was deleted. I meant to say keeping a separate header file for the protocol defintion might be a good idea. That way it is kept separate from the implementation details