From: Christoph Hellwig <hch@infradead.org>
To: KY Srinivasan <kys@microsoft.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
"Abhishek Kane (Mindtree Consulting PVT LTD)"
<v-abkane@microsoft.com>, Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [PATCH 23/40] Staging: hv: storvsc: Introduce code to manage IDE devices using storvsc HBA
Date: Fri, 1 Jul 2011 04:19:32 -0400 [thread overview]
Message-ID: <20110701081932.GD28322@infradead.org> (raw)
In-Reply-To: <6E21E5352C11B742B20C142EB499E0480816C2EF@TK5EX14MBXC126.redmond.corp.microsoft.com>
On Thu, Jun 30, 2011 at 09:38:34PM +0000, KY Srinivasan wrote:
> > > +#define HV_MAX_IDE_DEVICES 4
> > > +#define HV_IDE_BASE_CHANNEL 10
> > > +#define HV_IDE0_DEV1 HV_IDE_BASE_CHANNEL
> > > +#define HV_IDE0_DEV2 (HV_IDE_BASE_CHANNEL + 1)
> > > +#define HV_IDE1_DEV1 (HV_IDE_BASE_CHANNEL + 2)
> > > +#define HV_IDE1_DEV2 (HV_IDE_BASE_CHANNEL + 3)
> >
> > This at last needs a good explanation of why these devices are called
> > IDE if they actually aren't. I know you've explained the reason to me
> > before, but it should also be in the code.
>
> These devices are configured as IDE devices for the guest. The current
> emulator supports 2 IDE controllers for a total of potentially 4 devices.
> I did this to support all these 4 devices under one scsi host and used the
> channel information to get at the correct device in the I/O path.
> So, if you go to a model with one host per device, this would not be required.
Either way the driver should have a nice comment somewhere explaining
why you have disks that are named IDE but handled spoken to using SCSI
with explicit discovery.
> > but more importanly what does path actually stand for here? Opencoding
> > this into the caller and adding proper comments explaining the scheme
> > might be more readable.
>
> In the blkvsc driver, the path/target info was used to properly identify the
> device - (a) the device was under the first or second IDE controller and (b)
> whether it is the first or second device under the controller.
Yeah, that's what I got from reading the code. What confuses me is the
"path" terminology which doesn't really map to any normal nomenclature.
next prev parent reply other threads:[~2011-07-01 8:19 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 14:38 [PATCH 00/40] Staging: hv: Driver cleanup K. Y. Srinivasan
2011-06-29 14:38 ` [PATCH 01/40] Staging: hv: storvsc: Do not aquire an unnecessary reference on stor_device K. Y. Srinivasan
2011-06-29 14:38 ` [PATCH 02/40] Staging: hv: storvsc: Rename must_get_stor_device() K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 03/40] Staging: hv: storvsc: Rename get_stor_device() K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 04/40] Staging: hv: storvsc: Cleanup alloc_stor_device() K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 05/40] Staging: hv: storvsc: Introduce state to manage the lifecycle of stor device K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 06/40] Staging: hv: vmbus: Introduce a lock to protect the ext field in hv_device K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 07/40] Staging: hv: storvsc: Use the newly introduced lock in accessing ext field K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 08/40] Staging: hv: storvsc: Prevent outgoing traffic when stor dev is destroyed K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 09/40] Staging: hv: storvsc: Get rid of release_stor_device() by inlining the code K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 10/40] Staging: hv: storvsc: Get rid of final_release_stor_device() by inlining code K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 11/40] Staging: hv: storvsc: Leverage the spinlock to manage ref_cnt K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 12/40] Staging: hv: storvsc: Further cleanup reference counting of stor_device K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 13/40] Staging: hv: netvsc: Introduce code to properly manage outstanding sends K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 14/40] Staging: hv: netvsc: Inline the code for free_net_device() K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 15/40] Staging: hv: netvsc: Cleanup alloc_net_device() K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 16/40] Staging: hv: netvsc: Introduce state to manage the lifecycle of net device K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 17/40] Staging: hv: netvsc: Use the newly introduced lock in accessing ext field K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 18/40] Staging: hv: netvsc: Prevent outgoing traffic when netvsc dev is destroyed K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 19/40] Staging: hv: netvsc: Get rid of release_outbound_net_device() by inlining the code K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 20/40] Staging: hv: netvsc: Get rid of release_inbound_net_device() " K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 21/40] Staging: hv: netvsc: Leverage the spinlock to manage ref_cnt K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 22/40] Staging: hv: netvsc: Further cleanup reference counting of netvsc_device K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 23/40] Staging: hv: storvsc: Introduce code to manage IDE devices using storvsc HBA K. Y. Srinivasan
2011-06-30 19:38 ` Christoph Hellwig
2011-06-30 21:38 ` KY Srinivasan
2011-07-01 8:19 ` Christoph Hellwig [this message]
2011-06-29 14:39 ` [PATCH 24/40] Staging: hv: storvsc: On I/O get the correct IDE device K. Y. Srinivasan
2011-06-30 19:40 ` Christoph Hellwig
2011-06-30 21:15 ` KY Srinivasan
2011-07-01 8:17 ` Christoph Hellwig
2011-07-01 13:01 ` KY Srinivasan
2011-07-01 13:27 ` Christoph Hellwig
2011-06-29 14:39 ` [PATCH 25/40] Staging: hv: storvsc: Add state to manage the lifecycle of emulated HBA K. Y. Srinivasan
2011-06-30 19:44 ` Christoph Hellwig
2011-06-29 14:39 ` [PATCH 26/40] Staging: hv: storvsc: Handle probing IDE devices K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 27/40] Staging: hv: storvsc: Handle IDE devices correctly in storvsc_remove() K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 28/40] Staging: hv: storvsc: Handle IDE devices using the storvsc driver K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 29/40] Staging: hv: storvsc: Optimize bounce buffer handling for the "write" case K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 30/40] Staging: hv: storvsc: Optimize the bounce buffer handling in the "read" case K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 31/40] Staging: hv: storvsc: Get rid of blkvsc_drv.c as this code is not used K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 32/40] Staging: hv: storvsc: Include storvsc.c in storvsc_drv.c K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 33/40] Staging: hv: storvsc: Cleanup storvsc_drv.c after adding the contents of storvsc.c K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 34/40] Staging: hv: storvsc: Add the contents of hyperv_storage.h to storvsc_drv.c K. Y. Srinivasan
2011-06-30 19:45 ` Christoph Hellwig
2011-06-30 20:13 ` KY Srinivasan
2011-07-01 8:16 ` Christoph Hellwig
2011-07-01 12:48 ` KY Srinivasan
2011-07-05 16:12 ` Greg KH
2011-06-29 14:39 ` [PATCH 35/40] Staging: hv: storvsc: Make storvsc_dev_add() a static function K. Y. Srinivasan
2011-06-30 19:45 ` Christoph Hellwig
2011-06-29 14:39 ` [PATCH 36/40] Staging: hv: storvsc: Make storvsc_dev_remove() " K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 37/40] Staging: hv: storvsc: Make storvsc_do_io() " K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 38/40] Staging: hv: storvsc: Fixup srb_status for INQUIRY and MODE_SENSE K. Y. Srinivasan
2011-06-30 19:47 ` Christoph Hellwig
2011-06-30 19:59 ` KY Srinivasan
2011-07-01 8:00 ` Christoph Hellwig
2011-06-29 14:39 ` [PATCH 39/40] Staging: hv: storvsc: In case of scsi errors offline the device K. Y. Srinivasan
2011-06-29 14:39 ` [PATCH 40/40] Staging: hv: storvsc: No need to copy from bounce buffer in case of failure K. Y. Srinivasan
2011-07-05 16:14 ` [PATCH 01/40] Staging: hv: storvsc: Do not aquire an unnecessary reference on stor_device Greg KH
2011-07-05 16:43 ` KY Srinivasan
2011-06-30 19:33 ` [PATCH 00/40] Staging: hv: Driver cleanup Christoph Hellwig
2011-06-30 23:28 ` KY Srinivasan
2011-07-01 8:21 ` Christoph Hellwig
2011-07-01 13:31 ` KY Srinivasan
2011-06-30 23:32 ` KY Srinivasan
2011-06-30 23:48 ` Stephen Hemminger
2011-07-01 0:19 ` KY Srinivasan
2011-07-01 4:45 ` Stephen Hemminger
2011-07-01 13:25 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701081932.GD28322@infradead.org \
--to=hch@infradead.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v-abkane@microsoft.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).