From: Greg KH <greg@kroah.com>
To: KY Srinivasan <kys@microsoft.com>
Cc: "gregkh@suse.de" <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [PATCH 15/77] Staging: hv: blkvsc: Add the appropriate MODULE_ALIAS() line
Date: Tue, 5 Jul 2011 20:42:28 -0700 [thread overview]
Message-ID: <20110706034228.GA4291@kroah.com> (raw)
In-Reply-To: <6E21E5352C11B742B20C142EB499E0480816D27E@TK5EX14MBXC126.redmond.corp.microsoft.com>
On Wed, Jul 06, 2011 at 12:40:42AM +0000, KY Srinivasan wrote:
> > > diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
> > > index 5842db8..9496abe 100644
> > > --- a/drivers/staging/hv/blkvsc_drv.c
> > > +++ b/drivers/staging/hv/blkvsc_drv.c
> > > @@ -1027,5 +1027,6 @@ static void __exit blkvsc_exit(void)
> > > MODULE_LICENSE("GPL");
> > > MODULE_VERSION(HV_DRV_VERSION);
> > > MODULE_DESCRIPTION("Microsoft Hyper-V virtual block driver");
> > > +MODULE_ALIAS("vmbus:hv_block");
> >
> > No, these should be automagically generated with the MODULE_DEVICE_ID()
> > macro that you use in the module with the GUID there, instead of this.
>
> I think you mean MODULE_DEVICE_TABLE()?
Yes, sorry for the typo.
> I actually went down that path first
> adding code to file2alias.c for parsing the vmbus ID table. Given that this approach
> would make it impossible to support auto-loading of these drivers
> on many of the released kernels,
Wait, what? What is a "released kernel"? We are working on the
in-kernel patch, we don't care about older distros/releases for this
work at all. Also, it doesn't make sense at all, why would the change I
asked for make any difference on older distros/kernels?
> I chose to go with the MODULE_ALIAS() macro that did not need any
> changes outside our drivers. In both methods, the formatting of the
> name is bus specific since I would be writing the code to parse the
> table in file2alias.c.
Yes, that is what is needed to be done.
> Granted, I have been quite unimaginative in my alias names, but I
> thought they were reasonably descriptive. If at all possible, for the
> reasons listed above, I would prefer to use the MODULE_ALIAS() macro
> (I could embed all or part of the guid in the alias). Let me know.
Please do the correct thing and use MODULE_DEVICE_TABLE().
thanks,
greg k-h
next prev parent reply other threads:[~2011-07-06 3:42 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 20:16 [PATCH 00/77] Staging: hv: Driver cleanup K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 01/77] Staging: hv: vmbus: Increase the timeout value in the vmbus driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 02/77] Staging: hv: netvsc: Increase the timeout value in the netvsc driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 03/77] Staging: hv: storvsc: Increase the timeout value in the storvsc driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 04/77] Staging: hv: netvsc: Fix a bug in accounting transmit slots K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 05/77] Staging: hv: vmbus: Properly handle the error in hv_acpi_init() K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 06/77] Staging: hv: vmbus: VMBUS is an ACPI enumerated device, get rid of the PCI signature K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 07/77] Staging: hv: vmbus: Introduce a function to map the dev_type guid to a name K. Y. Srinivasan
2011-07-05 16:01 ` Greg KH
2011-06-16 20:16 ` [PATCH 08/77] Staging: hv: vmbus: Introduce vmbus ID space in struct hv_driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 09/77] Staging: hv: blkvsc: Use the newly introduced vmbus ID in the blockvsc driver K. Y. Srinivasan
2011-07-05 16:04 ` Greg KH
2011-06-16 20:16 ` [PATCH 10/77] Staging: hv: storvsc: Use the newly introduced vmbus ID in storvsc driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 11/77] Staging: hv: netvsc: Use the newly introduced vmbus ID in netvsc driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 12/77] Staging: hv: mousevsc: Use the newly introduced vmbus ID in mouse driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 13/77] Staging: hv: vmbus: Introduce a human readable device type field to struct hv_device K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 14/77] Staging: hv: util: Make hv_utils a vmbus device driver K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 15/77] Staging: hv: blkvsc: Add the appropriate MODULE_ALIAS() line K. Y. Srinivasan
2011-07-05 16:06 ` Greg KH
2011-07-06 0:40 ` KY Srinivasan
2011-07-06 3:42 ` Greg KH [this message]
2011-07-06 14:55 ` KY Srinivasan
2011-07-06 15:02 ` Greg KH
2011-07-06 15:17 ` KY Srinivasan
2011-07-06 15:29 ` Greg KH
2011-07-06 15:47 ` KY Srinivasan
2011-06-16 20:16 ` [PATCH 16/77] Staging: hv: storvsc: " K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 17/77] Staging: hv: netvsc: " K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 18/77] Staging: hv: mousevsc: " K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 19/77] Staging: hv: util: " K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 20/77] Staging: hv: vmbus: Cleanup the vmbus_uevent() code K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 21/77] Staging: hv: vmbus: Get rid of an unnecessary include line in vmbus_drv.c K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 22/77] Staging: hv: storvsc: Get rid of the DMI signature K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 23/77] Staging: hv: netvsc: Get rid of the PCI signature K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 24/77] Staging: hv: netvsc: Get rid of the DMI signature in netvsc_drv.c K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 25/77] Staging: hv: util: Get rid of the DMI signature in hv_util.c K. Y. Srinivasan
2011-06-16 20:16 ` [PATCH 26/77] Staging: hv: util: Get rid of the PCI " K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 27/77] Staging: hv: vmbus: Cleanup vmbus_match() function K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 28/77] Staging: hv: blkvsc: Get rid of the dev_type guid from blkvsc_drv.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 29/77] Staging: hv: storvsc: Get rid of the device type guid from storvsc_drv.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 30/77] Staging: hv: netvsc: Get rid of the dev_type guid from netvsc.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 31/77] Staging: hv: netvsc: Initialize the driver name directly K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 32/77] Staging: hv: netvsc: Get rid of the driver name initialization in netvsc.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 33/77] Staging: hv: netvsc: Get rid of the empty function netvsc_initialize() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 34/77] Staging: hv: vmbus: Get rid of the unused name field in struct hv_driver K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 35/77] Staging: hv: mouse: Get rid of the dev_type guid in hv_mouse.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 36/77] Staging: hv: vmbus: Cleanup the code displaying class_id K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 37/77] Staging: hv: vmbus: Do not initialize dev_type guid in vmbus_child_device_create() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 38/77] Staging: hv: vmbus: Get rid of the unused dev_type field in hv_device and hv_driver K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 39/77] Staging: hv: vmbus: Get rid of the device_id attribute K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 40/77] Staging: hv: vmbus: Get rid of some unnecessary comments K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 41/77] Staging: hv: vmbus: Cleanup unnecessary comments in hv.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 42/77] Staging: hv: vmbus: Cleanup error handling in hv_init() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 43/77] Staging: hv: vmbus: Get rid of unnecessay comments in connection.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 44/77] Staging: hv: vmbus: Get rid of the function dump_gpadl_body() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 45/77] Staging: hv: vmbus: Get rid of the function dump_gpadl_header() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 46/77] Staging: hv: vmbus: Rename openMsg to open_msg in channel.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 47/77] Staging: hv: vmbus: Get rid of unnecessary comments " K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 48/77] Staging: hv: vmbus: Change the variable name openInfo to open_info " K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 49/77] Staging: hv: vmbus: Cleanup error values in ringbuffer.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 50/77] Staging: hv: vmbus: Cleanup the error return value in vmbus_recvpacket_raw() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 51/77] Staging: hv: netvsc: Get rid of an unnecessary print statement in netvsc_probe() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 52/77] Staging: hv: vmbus: Retry vmbus_post_msg() before giving up K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 53/77] Staging: hv: storvsc: Cleanup error handling in storvsc_dev_add() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 54/77] Staging: hv: storvsc: Cleanup error handling in storvsc_channel_init() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 55/77] Staging: hv: storvsc: Cleanup error handling in storvsc_connect_to_vsp() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 56/77] Staging: hv: storvsc: Cleanup error handling in storvsc_do_io() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 57/77] Storage: hv: storvsc: Get rid of some unnecessary DPRINTs from storvsc.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 58/77] Staging: hv: storvsc: Fix/cleanup some dated comments in storvsc.c K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 59/77] Staging: hv: storvsc: Cleanup returned error code in storvsc_host_reset() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 60/77] Staging: hv: storvsc: Cleanup error code returned in storvsc_probe() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 61/77] Staging: hv: storvsc: Cleanup returned error code in storvsc_drv_init() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 62/77] Staging: hv: netvsc: Cleanup the returned error code in netvsc_probe() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 63/77] Staging: hv: netvsc: Cleanup error return codes in netvsc_destroy_recv_buf() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 64/77] Staging: hv: netvsc: Cleanup error return values in netvsc_init_recv_buf() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 65/77] Staging: hv: netvsc: Cleanup error returns in netvsc_connect_vsp() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 66/77] Staging: hv: netvsc: Cleanup error return values in netvsc_send() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 67/77] Staging: hv: netvsc: Cleanup error return codes in netvsc_device_add() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 68/77] Staging: hv: netvsc: Cleanup error codes in rndis_filter_receive() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 69/77] Staging: hv: netvsc: Cleanup error code in rndis_filter_query_device() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 70/77] Staging: hv: netvsc: Cleanup error return values in rndis_filter_set_packet_filter() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 71/77] Staging: hv: netvsc: Cleanup error returns in rndis_filter_init_device() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 72/77] Staging: hv: netvsc: Cleanup error code in rndis_filter_device_add() K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 73/77] Staging: hv: mouse: Change the jump label Cleanup to cleanup K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 74/77] Staging: hv: mouse: Get rid of the unused PCI signature K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 75/77] Staging: hv: mouse: Disable auto-loading of the mouse driver K. Y. Srinivasan
2011-07-05 15:57 ` Greg KH
2011-07-05 16:10 ` KY Srinivasan
2011-07-05 16:18 ` Greg KH
2011-06-16 20:17 ` [PATCH 76/77] Staging: hv: netvsc: Change the jump label Cleanup to cleanup K. Y. Srinivasan
2011-06-16 20:17 ` [PATCH 77/77] Staging: hv: netvsc: Change the jump lable Exit to exit K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706034228.GA4291@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).