From: Greg KH <greg@kroah.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: devel@linuxdriverproject.org,
Haiyang Zhang <haiyangz@microsoft.com>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
virtualization@lists.osdl.org
Subject: Re: [PATCH 4/8] Staging: hv: vmbus: Fix checkpatch warnings
Date: Tue, 23 Aug 2011 16:16:57 -0700 [thread overview]
Message-ID: <20110823231657.GC9955@kroah.com> (raw)
In-Reply-To: <1311101065-23417-4-git-send-email-kys@microsoft.com>
On Tue, Jul 19, 2011 at 11:44:21AM -0700, K. Y. Srinivasan wrote:
> Fix checkpatch warnings in hv.c
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
> drivers/staging/hv/hv.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/hv/hv.c b/drivers/staging/hv/hv.c
> index e733173..14e6315 100644
> --- a/drivers/staging/hv/hv.c
> +++ b/drivers/staging/hv/hv.c
> @@ -111,7 +111,7 @@ static u64 do_hypercall(u64 control, void *input, void *output)
> u64 hv_status = 0;
> u64 input_address = (input) ? virt_to_phys(input) : 0;
> u64 output_address = (output) ? virt_to_phys(output) : 0;
> - volatile void *hypercall_page = hv_context.hypercall_page;
> + void *hypercall_page = hv_context.hypercall_page;
Are you sure? This was just someone being foolish? No other reason
someone tried to use volatile here?
greg k-h
next prev parent reply other threads:[~2011-08-23 23:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 18:43 [PATCH 0/8] Staging: hv: Driver cleanup K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 1/8] Staging: hv: vmbus: Fix a checkpatch warning in ring_buffer.c K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 2/8] Staging: hv: vmbus: Fix checkpatch warnings in connection.c K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 3/8] Staging: hv: tools: Fix a checkpatch warning in hv_kvp_daemon.c K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 4/8] Staging: hv: vmbus: Fix checkpatch warnings K. Y. Srinivasan
2011-08-23 23:16 ` Greg KH [this message]
2011-08-24 1:10 ` KY Srinivasan
2011-07-19 18:44 ` [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and warnings K. Y. Srinivasan
2011-07-19 19:28 ` Joe Perches
2011-07-19 22:46 ` KY Srinivasan
2011-07-19 18:44 ` [PATCH 6/8] Staging: hv: Get rid of checkpatch cleanup item K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 7/8] Staging: hv: Get rid of the vmbus merge item K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 8/8] Staging: hv: Update the TODO file K. Y. Srinivasan
2011-08-23 23:14 ` [PATCH 1/8] Staging: hv: vmbus: Fix a checkpatch warning in ring_buffer.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823231657.GC9955@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).