From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 10/59] Staging: hv: util: Make hv_utils a vmbus device driver Date: Tue, 30 Aug 2011 18:53:23 +0300 Message-ID: <20110830155323.GT3705@shale.localdomain> References: <1314290866-2644-1-git-send-email-kys@microsoft.com> <1314290965-2698-1-git-send-email-kys@microsoft.com> <1314290965-2698-10-git-send-email-kys@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1314290965-2698-10-git-send-email-kys@microsoft.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devel-bounces@linuxdriverproject.org Sender: devel-bounces@linuxdriverproject.org To: "K. Y. Srinivasan" Cc: devel@linuxdriverproject.org, Haiyang Zhang , gregkh@suse.de, linux-kernel@vger.kernel.org, virtualization@lists.osdl.org List-Id: virtualization@lists.linuxfoundation.org On Thu, Aug 25, 2011 at 09:48:36AM -0700, K. Y. Srinivasan wrote: > + util_drv.driver.name = driver_name; > + > + return vmbus_child_driver_register(&util_drv.driver); We should free the allocations if vmbus_child_driver_register() fails. regards, dan carpenter