From: Olaf Hering <olaf@aepfle.de>
To: Greg KH <gregkh@suse.de>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
virtualization@lists.osdl.org
Subject: Re: [PATCH] Staging: hv: storvsc: Show the modulename in /sys/class/scsi_host/*/proc_name
Date: Fri, 9 Sep 2011 10:45:23 +0200 [thread overview]
Message-ID: <20110909084523.GA20517@aepfle.de> (raw)
In-Reply-To: <20110908191237.GB8552@suse.de>
On Thu, Sep 08, Greg KH wrote:
> On Thu, Sep 08, 2011 at 06:26:50PM +0200, Olaf Hering wrote:
> > +++ b/drivers/staging/hv/storvsc_drv.c
> > @@ -1333,7 +1333,8 @@ static DEF_SCSI_QCMD(storvsc_queuecomman
> > /* Scsi driver */
> > static struct scsi_host_template scsi_driver = {
> > .module = THIS_MODULE,
> > - .name = "storvsc_host_t",
> > + .name = "hv_storvsc",
> > + .proc_name = "hv_storvsc",
>
> Shouldn't this be MODULE_NAME so it handles any potential name change in
> the future and makes it a bit more obvious as to what is going on here?
MODULE_NAME is just another define and appearently not used to assemble
a kernel module. Is DRV_NAME depreciated?
I think hv_storvsc and hv_netvsc should advertise their module names as
sysfs driver names. Digging into the hv history it could be that the
initial implementation had a storvsc.ko, and
c3260cfe8f08ca4564df61950cbebbb693aee292 introduced the hv_storvsc.ko
I will send a patch on top of that.
Olaf
next prev parent reply other threads:[~2011-09-09 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 16:26 [PATCH] Staging: hv: storvsc: Show the modulename in /sys/class/scsi_host/*/proc_name Olaf Hering
2011-09-08 16:55 ` KY Srinivasan
2011-09-08 19:12 ` Greg KH
2011-09-09 8:45 ` Olaf Hering [this message]
2011-09-09 15:24 ` Greg KH
2011-09-09 12:45 ` [PATCH] Staging: hv: storvsc: advertise hv_storvsc instead of storvsc as driver name Olaf Hering
2011-09-09 15:25 ` Greg KH
2011-09-09 12:46 ` [PATCH] Staging: hv: netvsc: advertise hv_netvsc instead of netvsc " Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909084523.GA20517@aepfle.de \
--to=olaf@aepfle.de \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).