From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: gregkh@suse.de, jkosina@suse.cz, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org, ohering@suse.com,
virtualization@lists.osdl.org, joe@perches.com,
devel@linuxdriverproject.org
Subject: Re: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging
Date: Sat, 29 Oct 2011 09:32:40 +0300 [thread overview]
Message-ID: <20111029063240.GH14881@longonot.mountain> (raw)
In-Reply-To: <alpine.LNX.2.00.1110290041500.31615@swampdragon.chaosbits.net>
On Sat, Oct 29, 2011 at 12:54:34AM +0200, Jesper Juhl wrote:
> > + default:
> > + pr_err("unhandled packet type %d, tid %llx len %d\n",
> > + desc->type,
> > + req_id,
> > + bytes_recvd);
>
> Why not:
>
> pr_err("unhandled packet type %d, tid %llx
> len %d\n", desc->type, req_id, bytes_recvd);
Because then the printk would be messed up? Your final printed
string would look like:
"unhandled packet type %d, tid %llx
len %d\n"
Don't break strings up across lines because it breaks grep. If K. Y.
wants to put all the parameters on one line instead of three that
would probably be better, but in the end who cares?
regards,
dan carpenter
next prev parent reply other threads:[~2011-10-29 6:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 22:35 [PATCH 1/1] Staging: hv: Move the mouse driver out of staging K. Y. Srinivasan
2011-10-28 22:54 ` Jesper Juhl
2011-10-29 6:32 ` Dan Carpenter [this message]
2011-10-30 16:16 ` KY Srinivasan
2011-11-02 22:59 ` Jesper Juhl
2011-11-02 23:04 ` KY Srinivasan
2011-11-05 6:47 ` Dmitry Torokhov
2011-11-07 1:04 ` KY Srinivasan
2011-11-07 5:51 ` Dmitry Torokhov
2011-11-09 0:45 ` KY Srinivasan
2011-11-13 20:02 ` Jiri Kosina
2011-11-14 2:42 ` KY Srinivasan
2011-11-13 20:01 ` Jiri Kosina
2011-11-14 0:47 ` Dmitry Torokhov
2011-11-14 2:45 ` KY Srinivasan
2011-11-14 2:40 ` KY Srinivasan
-- strict thread matches above, loose matches on Subject: below --
2011-11-09 17:23 K. Y. Srinivasan
2011-10-26 16:08 K. Y. Srinivasan
2011-10-27 10:37 ` Olaf Hering
2011-10-27 13:25 ` KY Srinivasan
2011-10-28 18:47 ` Jiri Kosina
2011-10-28 19:50 ` KY Srinivasan
2011-10-28 20:03 ` Greg KH
2011-10-28 20:28 ` KY Srinivasan
2011-10-29 6:34 ` Greg KH
2011-10-29 14:09 ` KY Srinivasan
2011-10-29 17:05 ` Jiri Kosina
2011-10-30 16:16 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029063240.GH14881@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohering@suse.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox