From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4 Date: Sun, 1 Jan 2012 13:47:27 +0200 Message-ID: <20120101114727.GC25350@redhat.com> References: <20111229161523.GB2300@redhat.com> <20111230085205.GG4576@amit.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20111230085205.GG4576@amit.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Virtualization List List-Id: virtualization@lists.linuxfoundation.org On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote: > > > > > + if (!try_fill_recv(vi, GFP_KERNEL)) > > > + schedule_delayed_work(&vi->refill, 0); > > > > This needs to be switched to non reentrant wq too? > > Subsequent invocations could create problems? Note that this will be > the first item to be queued in the workqueue for the refill work. > > Amit See recent patches on net-next. We switched other calls to a non reentrant wq so I think same reasoning applies there.