From: Amit Shah <amit.shah@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4
Date: Tue, 3 Jan 2012 22:37:48 +0530 [thread overview]
Message-ID: <20120103170748.GE4536@amit.redhat.com> (raw)
In-Reply-To: <20120101114727.GC25350@redhat.com>
On (Sun) 01 Jan 2012 [13:47:27], Michael S. Tsirkin wrote:
> On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote:
> > >
> > > > + if (!try_fill_recv(vi, GFP_KERNEL))
> > > > + schedule_delayed_work(&vi->refill, 0);
> > >
> > > This needs to be switched to non reentrant wq too?
> >
> > Subsequent invocations could create problems? Note that this will be
> > the first item to be queued in the workqueue for the refill work.
> >
> > Amit
>
> See recent patches on net-next.
> We switched other calls to a non reentrant wq so I think same
> reasoning applies there.
There's a patch ordering issue; so this series should land after the
-net series is merged.
Rusty, do you want me to re-spin this patch on top of yours, or is
that something that you'll handle?
Amit
next prev parent reply other threads:[~2012-01-03 17:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 11:28 [PATCH v6 00/11] virtio: s4 support Amit Shah
2011-12-22 11:28 ` [PATCH v6 01/11] virtio: pci: switch to new PM API Amit Shah
2011-12-22 11:28 ` [PATCH v6 02/11] virtio: pci: add PM notification handlers for restore, freeze, thaw, poweroff Amit Shah
2011-12-22 11:28 ` [PATCH v6 03/11] virtio: console: Move vq and vq buf removal into separate functions Amit Shah
2011-12-22 11:28 ` [PATCH v6 04/11] virtio: console: Add freeze and restore handlers to support S4 Amit Shah
2011-12-22 11:28 ` [PATCH v6 05/11] virtio: blk: Move vq initialization to separate function Amit Shah
2011-12-22 11:28 ` [PATCH v6 06/11] virtio: blk: Add freeze, restore handlers to support S4 Amit Shah
2011-12-22 11:28 ` [PATCH v6 07/11] virtio: net: Move vq initialization into separate function Amit Shah
2011-12-22 11:28 ` [PATCH v6 08/11] virtio: net: Move vq and vq buf removal " Amit Shah
2011-12-22 11:28 ` [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4 Amit Shah
2011-12-29 16:15 ` Michael S. Tsirkin
2011-12-30 9:38 ` Amit Shah
2012-01-01 11:47 ` Michael S. Tsirkin
2012-01-03 17:07 ` Amit Shah [this message]
2012-01-04 2:49 ` Rusty Russell
2011-12-22 11:28 ` [PATCH v6 10/11] virtio: balloon: Move vq initialization into separate function Amit Shah
2011-12-22 11:28 ` [PATCH v6 11/11] virtio: balloon: Add freeze, restore handlers to support S4 Amit Shah
2011-12-29 4:32 ` [PATCH v6 00/11] virtio: s4 support Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103170748.GE4536@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).