* [PATCH 42/50] virtio_net: use dev_hw_addr_random() instead of random_ether_addr()
[not found] <1328735457-29986-1-git-send-email-danny.kukawka@bisect.de>
@ 2012-02-08 21:10 ` Danny Kukawka
[not found] ` <1328735457-29986-43-git-send-email-danny.kukawka@bisect.de>
1 sibling, 0 replies; 2+ messages in thread
From: Danny Kukawka @ 2012-02-08 21:10 UTC (permalink / raw)
To: Rusty Russell
Cc: Michael S. Tsirkin, netdev, Danny Kukawka, linux-kernel,
virtualization, David S. Miller
Use dev_hw_addr_random() instead of calling random_ether_addr()
to set addr_assign_type correctly to NET_ADDR_RANDOM.
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
drivers/net/virtio_net.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 4880aa8..69d36e1 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1061,7 +1061,7 @@ static int virtnet_probe(struct virtio_device *vdev)
if (virtio_config_val_len(vdev, VIRTIO_NET_F_MAC,
offsetof(struct virtio_net_config, mac),
dev->dev_addr, dev->addr_len) < 0)
- random_ether_addr(dev->dev_addr);
+ dev_hw_addr_random(dev, dev->dev_addr);
/* Set up our device-specific information */
vi = netdev_priv(dev);
--
1.7.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 42/50] virtio_net: use dev_hw_addr_random() instead of random_ether_addr()
[not found] ` <1328735457-29986-43-git-send-email-danny.kukawka@bisect.de>
@ 2012-02-09 9:35 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2012-02-09 9:35 UTC (permalink / raw)
To: Danny Kukawka
Cc: netdev, Danny Kukawka, linux-kernel, virtualization,
David S. Miller
On Wed, Feb 08, 2012 at 10:10:49PM +0100, Danny Kukawka wrote:
> Use dev_hw_addr_random() instead of calling random_ether_addr()
> to set addr_assign_type correctly to NET_ADDR_RANDOM.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 4880aa8..69d36e1 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1061,7 +1061,7 @@ static int virtnet_probe(struct virtio_device *vdev)
> if (virtio_config_val_len(vdev, VIRTIO_NET_F_MAC,
> offsetof(struct virtio_net_config, mac),
> dev->dev_addr, dev->addr_len) < 0)
> - random_ether_addr(dev->dev_addr);
> + dev_hw_addr_random(dev, dev->dev_addr);
>
> /* Set up our device-specific information */
> vi = netdev_priv(dev);
> --
> 1.7.7.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-09 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1328735457-29986-1-git-send-email-danny.kukawka@bisect.de>
2012-02-08 21:10 ` [PATCH 42/50] virtio_net: use dev_hw_addr_random() instead of random_ether_addr() Danny Kukawka
[not found] ` <1328735457-29986-43-git-send-email-danny.kukawka@bisect.de>
2012-02-09 9:35 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).