* Re: [Xen-devel] [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps [not found] <20120109075911.GA4049@core.coreip.homeip.net> @ 2012-01-09 10:43 ` Andrew Jones 2012-01-09 17:51 ` [PATCH 2/4 v2] " Andrew Jones 0 siblings, 1 reply; 7+ messages in thread From: Andrew Jones @ 2012-01-09 10:43 UTC (permalink / raw) To: Dmitry Torokhov Cc: jeremy, xen-devel, konrad wilk, FlorianSchandinat, virtualization, Konrad Rzeszutek Wilk ----- Original Message ----- > Hi Andrew, > > On Fri, Jan 06, 2012 at 10:58:06AM -0500, Andrew Jones wrote: > > > > > > ----- Original Message ----- > > > On Fri, Jan 06, 2012 at 10:43:09AM +0100, Andrew Jones wrote: > > > > PV-on-HVM guests may want to use the xen keyboard/mouse > > > > frontend, > > > > but > > > > they don't use the xen frame buffer frontend. For this case it > > > > doesn't > > > > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on > > > > XEN_FBDEV_FRONTEND. The opposite direction always makes more > > > > sense, > > > > i.e. > > > > if you're using xenfb, then you'll want xenkbd. Switch the > > > > dependencies. > > > > > > You need to CC as well these people that have 'maintainer' field > > > on > > > them: > > > > > > konrad@phenom:~/work/linux$ scripts/get_maintainer.pl -f > > > drivers/video/Kconfig > > > Florian Tobias Schandinat <FlorianSchandinat@gmx.de> > > > (maintainer:FRAMEBUFFER LAYER) > > > linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER) > > > linux-kernel@vger.kernel.org (open list) > > > konrad@phenom:~/work/linux$ scripts/get_maintainer.pl -f > > > drivers/input/misc/Kconfig > > > Dmitry Torokhov <dmitry.torokhov@gmail.com> (maintainer:INPUT > > > (KEYBOARD,...,commit_signer:9/16=56%) > > > Samuel Ortiz <sameo@linux.intel.com> (commit_signer:3/16=19%) > > > Anirudh Ghayal <aghayal@codeaurora.org> (commit_signer:2/16=12%) > > > Peter Ujfalusi <peter.ujfalusi@ti.com> (commit_signer:2/16=12%) > > > Alan Cox <alan@linux.intel.com> (commit_signer:2/16=12%) > > > linux-input@vger.kernel.org (open list:INPUT (KEYBOARD,...) > > > linux-kernel@vger.kernel.org (open list) > > > > > > > Thanks. Replied with them in CC. > > > > Drew > > > > > > > > > > Signed-off-by: Andrew Jones <drjones@redhat.com> > > > > --- > > > > drivers/input/misc/Kconfig | 2 +- > > > > drivers/video/Kconfig | 1 + > > > > 2 files changed, 2 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/drivers/input/misc/Kconfig > > > > b/drivers/input/misc/Kconfig > > > > index 22d875f..36c15bf 100644 > > > > --- a/drivers/input/misc/Kconfig > > > > +++ b/drivers/input/misc/Kconfig > > > > @@ -533,7 +533,7 @@ config INPUT_CMA3000_I2C > > > > > > > > config INPUT_XEN_KBDDEV_FRONTEND > > > > tristate "Xen virtual keyboard and mouse support" > > > > - depends on XEN_FBDEV_FRONTEND > > > > + depends on XEN > > This is OK with me. > > > > > default y > > > > select XEN_XENBUS_FRONTEND > > > > help > > > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > > > index d83e967..269b299 100644 > > > > --- a/drivers/video/Kconfig > > > > +++ b/drivers/video/Kconfig > > > > @@ -2269,6 +2269,7 @@ config XEN_FBDEV_FRONTEND > > > > select FB_SYS_IMAGEBLIT > > > > select FB_SYS_FOPS > > > > select FB_DEFERRED_IO > > > > + select INPUT_XEN_KBDDEV_FRONTEND > > But here you need to either depend on or select INPUT as select does > not > resolve dependencies for selected symbol. > Would I actually need 'select INPUT' and select 'INPUT_MISC'? Maybe 'depends on' would just be cleaner and safer. I'll send a V2. Thanks, Drew > Thanks. > > -- > Dmitry > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps 2012-01-09 10:43 ` [Xen-devel] [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps Andrew Jones @ 2012-01-09 17:51 ` Andrew Jones 2012-01-11 16:11 ` [Xen-devel] " Konrad Rzeszutek Wilk 0 siblings, 1 reply; 7+ messages in thread From: Andrew Jones @ 2012-01-09 17:51 UTC (permalink / raw) To: xen-devel Cc: jeremy, virtualization, dmitry.torokhov, FlorianSchandinat, konrad.wilk PV-on-HVM guests may want to use the xen keyboard/mouse frontend, but they don't use the xen frame buffer frontend. For this case it doesn't make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on XEN_FBDEV_FRONTEND. The opposite direction always makes more sense, i.e. if you're using xenfb, then you'll want xenkbd. Switch the dependencies. Signed-off-by: Andrew Jones <drjones@redhat.com> --- drivers/input/misc/Kconfig | 2 +- drivers/video/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index 22d875f..36c15bf 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -533,7 +533,7 @@ config INPUT_CMA3000_I2C config INPUT_XEN_KBDDEV_FRONTEND tristate "Xen virtual keyboard and mouse support" - depends on XEN_FBDEV_FRONTEND + depends on XEN default y select XEN_XENBUS_FRONTEND help diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index d83e967..3e38c2f 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -2263,7 +2263,7 @@ config FB_VIRTUAL config XEN_FBDEV_FRONTEND tristate "Xen virtual frame buffer support" - depends on FB && XEN + depends on FB && XEN && INPUT_XEN_KBDDEV_FRONTEND select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT -- 1.7.7.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps 2012-01-09 17:51 ` [PATCH 2/4 v2] " Andrew Jones @ 2012-01-11 16:11 ` Konrad Rzeszutek Wilk 2012-01-11 16:29 ` Andrew Jones 0 siblings, 1 reply; 7+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-01-11 16:11 UTC (permalink / raw) To: Andrew Jones Cc: jeremy, xen-devel, konrad.wilk, FlorianSchandinat, dmitry.torokhov, virtualization On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote: > PV-on-HVM guests may want to use the xen keyboard/mouse frontend, but > they don't use the xen frame buffer frontend. For this case it doesn't Ok, but PV does? > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on > XEN_FBDEV_FRONTEND. The opposite direction always makes more sense, i.e. > if you're using xenfb, then you'll want xenkbd. Switch the dependencies. That sounds like it would be universal irregardless if it is PV or PVonHVM? > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > drivers/input/misc/Kconfig | 2 +- > drivers/video/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index 22d875f..36c15bf 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -533,7 +533,7 @@ config INPUT_CMA3000_I2C > > config INPUT_XEN_KBDDEV_FRONTEND > tristate "Xen virtual keyboard and mouse support" > - depends on XEN_FBDEV_FRONTEND > + depends on XEN > default y > select XEN_XENBUS_FRONTEND > help > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index d83e967..3e38c2f 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -2263,7 +2263,7 @@ config FB_VIRTUAL > > config XEN_FBDEV_FRONTEND > tristate "Xen virtual frame buffer support" > - depends on FB && XEN > + depends on FB && XEN && INPUT_XEN_KBDDEV_FRONTEND > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT > -- > 1.7.7.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps 2012-01-11 16:11 ` [Xen-devel] " Konrad Rzeszutek Wilk @ 2012-01-11 16:29 ` Andrew Jones 2012-03-15 17:23 ` Konrad Rzeszutek Wilk 0 siblings, 1 reply; 7+ messages in thread From: Andrew Jones @ 2012-01-11 16:29 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: jeremy, xen-devel, konrad wilk, FlorianSchandinat, dmitry torokhov, virtualization ----- Original Message ----- > On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote: > > PV-on-HVM guests may want to use the xen keyboard/mouse frontend, > > but > > they don't use the xen frame buffer frontend. For this case it > > doesn't > > Ok, but PV does? > > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on > > XEN_FBDEV_FRONTEND. The opposite direction always makes more sense, > > i.e. > > if you're using xenfb, then you'll want xenkbd. Switch the > > dependencies. > > That sounds like it would be universal irregardless if it is > PV or PVonHVM? This patch makes it such that if you want to use both, then you must select both. It also says that if you want FB, then you need the KBD. However, if you only want the KBD then you're fine with just that. So there isn't any risk of breaking configs designed to use FB, because FB should be manually selected for those configs anyway. Drew > > > > Signed-off-by: Andrew Jones <drjones@redhat.com> > > --- > > drivers/input/misc/Kconfig | 2 +- > > drivers/video/Kconfig | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/input/misc/Kconfig > > b/drivers/input/misc/Kconfig > > index 22d875f..36c15bf 100644 > > --- a/drivers/input/misc/Kconfig > > +++ b/drivers/input/misc/Kconfig > > @@ -533,7 +533,7 @@ config INPUT_CMA3000_I2C > > > > config INPUT_XEN_KBDDEV_FRONTEND > > tristate "Xen virtual keyboard and mouse support" > > - depends on XEN_FBDEV_FRONTEND > > + depends on XEN > > default y > > select XEN_XENBUS_FRONTEND > > help > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > index d83e967..3e38c2f 100644 > > --- a/drivers/video/Kconfig > > +++ b/drivers/video/Kconfig > > @@ -2263,7 +2263,7 @@ config FB_VIRTUAL > > > > config XEN_FBDEV_FRONTEND > > tristate "Xen virtual frame buffer support" > > - depends on FB && XEN > > + depends on FB && XEN && INPUT_XEN_KBDDEV_FRONTEND > > select FB_SYS_FILLRECT > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > -- > > 1.7.7.5 > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps 2012-01-11 16:29 ` Andrew Jones @ 2012-03-15 17:23 ` Konrad Rzeszutek Wilk 2012-03-16 6:24 ` Dmitry Torokhov 0 siblings, 1 reply; 7+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-03-15 17:23 UTC (permalink / raw) To: Andrew Jones Cc: jeremy, xen-devel, FlorianSchandinat, dmitry torokhov, virtualization, Konrad Rzeszutek Wilk On Wed, Jan 11, 2012 at 11:29:20AM -0500, Andrew Jones wrote: > > > ----- Original Message ----- > > On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote: > > > PV-on-HVM guests may want to use the xen keyboard/mouse frontend, > > > but > > > they don't use the xen frame buffer frontend. For this case it > > > doesn't > > > > Ok, but PV does? > > > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on > > > XEN_FBDEV_FRONTEND. The opposite direction always makes more sense, > > > i.e. > > > if you're using xenfb, then you'll want xenkbd. Switch the > > > dependencies. > > > > That sounds like it would be universal irregardless if it is > > PV or PVonHVM? > > This patch makes it such that if you want to use both, then you must > select both. It also says that if you want FB, then you need the > KBD. However, if you only want the KBD then you're fine with just > that. So there isn't any risk of breaking configs designed to use > FB, because FB should be manually selected for those configs anyway. Dmitry, I am OK with this patch. Should I pick it up on my tree for 3.4 or are you OK doing it via your tree? Thanks! > > Drew > > > > > > > Signed-off-by: Andrew Jones <drjones@redhat.com> > > > --- > > > drivers/input/misc/Kconfig | 2 +- > > > drivers/video/Kconfig | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/input/misc/Kconfig > > > b/drivers/input/misc/Kconfig > > > index 22d875f..36c15bf 100644 > > > --- a/drivers/input/misc/Kconfig > > > +++ b/drivers/input/misc/Kconfig > > > @@ -533,7 +533,7 @@ config INPUT_CMA3000_I2C > > > > > > config INPUT_XEN_KBDDEV_FRONTEND > > > tristate "Xen virtual keyboard and mouse support" > > > - depends on XEN_FBDEV_FRONTEND > > > + depends on XEN > > > default y > > > select XEN_XENBUS_FRONTEND > > > help > > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > > index d83e967..3e38c2f 100644 > > > --- a/drivers/video/Kconfig > > > +++ b/drivers/video/Kconfig > > > @@ -2263,7 +2263,7 @@ config FB_VIRTUAL > > > > > > config XEN_FBDEV_FRONTEND > > > tristate "Xen virtual frame buffer support" > > > - depends on FB && XEN > > > + depends on FB && XEN && INPUT_XEN_KBDDEV_FRONTEND > > > select FB_SYS_FILLRECT > > > select FB_SYS_COPYAREA > > > select FB_SYS_IMAGEBLIT > > > -- > > > 1.7.7.5 > > > > > > > > > _______________________________________________ > > > Xen-devel mailing list > > > Xen-devel@lists.xensource.com > > > http://lists.xensource.com/xen-devel > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps 2012-03-15 17:23 ` Konrad Rzeszutek Wilk @ 2012-03-16 6:24 ` Dmitry Torokhov 2012-03-16 14:48 ` Konrad Rzeszutek Wilk 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Torokhov @ 2012-03-16 6:24 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: Andrew Jones, xen-devel, FlorianSchandinat, jeremy, virtualization, Konrad Rzeszutek Wilk On Thu, Mar 15, 2012 at 01:23:05PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 11, 2012 at 11:29:20AM -0500, Andrew Jones wrote: > > > > > > ----- Original Message ----- > > > On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote: > > > > PV-on-HVM guests may want to use the xen keyboard/mouse frontend, > > > > but > > > > they don't use the xen frame buffer frontend. For this case it > > > > doesn't > > > > > > Ok, but PV does? > > > > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on > > > > XEN_FBDEV_FRONTEND. The opposite direction always makes more sense, > > > > i.e. > > > > if you're using xenfb, then you'll want xenkbd. Switch the > > > > dependencies. > > > > > > That sounds like it would be universal irregardless if it is > > > PV or PVonHVM? > > > > This patch makes it such that if you want to use both, then you must > > select both. It also says that if you want FB, then you need the > > KBD. However, if you only want the KBD then you're fine with just > > that. So there isn't any risk of breaking configs designed to use > > FB, because FB should be manually selected for those configs anyway. > > Dmitry, > > I am OK with this patch. Should I pick it up on my tree for 3.4 or > are you OK doing it via your tree? Konrad, I don't have a good copy of the patch so it you could pick it up that would be great. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps 2012-03-16 6:24 ` Dmitry Torokhov @ 2012-03-16 14:48 ` Konrad Rzeszutek Wilk 0 siblings, 0 replies; 7+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-03-16 14:48 UTC (permalink / raw) To: Dmitry Torokhov Cc: Andrew Jones, xen-devel, FlorianSchandinat, jeremy, virtualization, Konrad Rzeszutek Wilk On Thu, Mar 15, 2012 at 11:24:28PM -0700, Dmitry Torokhov wrote: > On Thu, Mar 15, 2012 at 01:23:05PM -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, Jan 11, 2012 at 11:29:20AM -0500, Andrew Jones wrote: > > > > > > > > > ----- Original Message ----- > > > > On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote: > > > > > PV-on-HVM guests may want to use the xen keyboard/mouse frontend, > > > > > but > > > > > they don't use the xen frame buffer frontend. For this case it > > > > > doesn't > > > > > > > > Ok, but PV does? > > > > > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on > > > > > XEN_FBDEV_FRONTEND. The opposite direction always makes more sense, > > > > > i.e. > > > > > if you're using xenfb, then you'll want xenkbd. Switch the > > > > > dependencies. > > > > > > > > That sounds like it would be universal irregardless if it is > > > > PV or PVonHVM? > > > > > > This patch makes it such that if you want to use both, then you must > > > select both. It also says that if you want FB, then you need the > > > KBD. However, if you only want the KBD then you're fine with just > > > that. So there isn't any risk of breaking configs designed to use > > > FB, because FB should be manually selected for those configs anyway. > > > > Dmitry, > > > > I am OK with this patch. Should I pick it up on my tree for 3.4 or > > are you OK doing it via your tree? > > Konrad, > > I don't have a good copy of the patch so it you could pick it up that > would be great. OK, will stick you Ack on it. Thx! > > Thanks. > > -- > Dmitry > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-03-16 14:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120109075911.GA4049@core.coreip.homeip.net>
2012-01-09 10:43 ` [Xen-devel] [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps Andrew Jones
2012-01-09 17:51 ` [PATCH 2/4 v2] " Andrew Jones
2012-01-11 16:11 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-01-11 16:29 ` Andrew Jones
2012-03-15 17:23 ` Konrad Rzeszutek Wilk
2012-03-16 6:24 ` Dmitry Torokhov
2012-03-16 14:48 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).