virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, KVM <kvm@vger.kernel.org>,
	SCSI <linux-scsi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	VIRTUAL <virtualization@lists.linux-foundation.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Ren Mingxin <renmx@cn.fujitsu.com>
Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming
Date: Wed, 4 Apr 2012 11:01:50 +0300	[thread overview]
Message-ID: <20120404080149.GC22658@redhat.com> (raw)
In-Reply-To: <20120402190045.GC16226@dhcp-172-17-108-109.mtv.corp.google.com>

On Mon, Apr 02, 2012 at 12:00:45PM -0700, Tejun Heo wrote:
> Hello, James.
> 
> On Mon, Apr 02, 2012 at 11:56:18AM -0700, James Bottomley wrote:
> > So if we're agreed no other devices going forwards should ever use this
> > interface, is there any point unifying the interface?  No matter how
> > many caveats you hedge it round with, putting the API in a central place
> > will be a bit like a honey trap for careless bears.   It might be safer
> > just to leave it buried in the three current drivers.
> 
> Yeah, that was my hope but I think it would be easier to enforce to
> have a common function which is clearly marked legacy so that new
> driver writers can go look for the naming code in the existing ones,
> find out they're all using the same function which is marked legacy
> and explains what to do for newer drivers.
> 
> Thanks.

I think I'm not the only one to be confused about the
preferred direction here.
James, do you agree to the approach above?

It would be nice to fix virtio block for 3.4, so
how about this:
- I'll just apply the original bugfix patch for 3.4 -
  it only affects virtio
- Ren will repost the refactoring patch on top, and we can
  keep up the discussion

Ren if you agree, can you make this a two patch series please?

> -- 
> tejun
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2012-04-04  8:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4F7581D4.4040301@cn.fujitsu.com>
2012-03-30  9:52 ` [PATCH 1/4] block: add function disk_name_format() into block core Ren Mingxin
2012-03-30  9:53 ` [PATCH 2/4] scsi: replace sd_format_disk_name() to disk_name_format() Ren Mingxin
2012-03-30  9:53 ` [PATCH 3/4] block: replace rssd_disk_name_format() " Ren Mingxin
2012-03-30  9:53 ` [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Ren Mingxin
2012-03-30  9:56 ` [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() James Bottomley
     [not found] ` <1333101375.2833.34.camel@dabdike>
2012-03-30 10:10   ` Ren Mingxin
     [not found] ` <4F7582B0.5010609@cn.fujitsu.com>
2012-03-30 11:22   ` [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Asias He
2012-03-31  1:14     ` Ren Mingxin
     [not found]     ` <4F765A72.6090006@cn.fujitsu.com>
2012-03-31  3:03       ` Asias He
2012-03-30 15:26   ` Tejun Heo
2012-03-30 15:28     ` Tejun Heo
2012-04-02  1:19       ` Ren Mingxin
     [not found]       ` <4F78FE89.2070707@cn.fujitsu.com>
2012-04-02  7:20         ` Michael S. Tsirkin
2012-04-02 18:52           ` Tejun Heo
2012-04-02 18:56             ` James Bottomley
     [not found]             ` <1333392978.2971.25.camel@dabdike>
2012-04-02 19:00               ` Tejun Heo
2012-04-04  8:01                 ` Michael S. Tsirkin [this message]
2012-04-09  3:47                   ` Ren Mingxin
     [not found]                   ` <4F825BE7.80204@cn.fujitsu.com>
2012-04-09  7:33                     ` Michael S. Tsirkin
2012-04-09  7:50                     ` Michael S. Tsirkin
2012-03-30 15:38     ` Tejun Heo
     [not found]     ` <20120330153828.GD28934@google.com>
2012-04-02  1:18       ` Ren Mingxin
2012-04-02  7:15     ` Michael S. Tsirkin
2012-04-12 20:17     ` Jeff Garzik
     [not found] ` <4F758297.5020600@cn.fujitsu.com>
2012-03-30 23:54   ` [PATCH 3/4] block: replace rssd_disk_name_format() to disk_name_format() Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]
     [not found]   ` <4F764778.1030406@micron.com>
2012-04-02  1:21     ` Ren Mingxin
2012-04-01 11:20 ` [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120404080149.GC22658@redhat.com \
    --to=mst@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=axboe@kernel.dk \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=renmx@cn.fujitsu.com \
    --cc=tj@kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).