From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [net-next V7 PATCH] virtio-net: send gratuitous packets when needed
Date: Sun, 15 Apr 2012 03:20:03 -0400 (EDT) [thread overview]
Message-ID: <20120415.032003.138761548777211783.davem@davemloft.net> (raw)
In-Reply-To: <20120415071223.GC3070@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Sun, 15 Apr 2012 10:12:23 +0300
> On Thu, Apr 12, 2012 at 02:43:52PM +0800, Jason Wang wrote:
>> As hypervior does not have the knowledge of guest network configuration, it's
>> better to ask guest to send gratuitous packets when needed.
>>
>> This patch implements VIRTIO_NET_F_GUEST_ANNOUNCE feature: hypervisor would
>> notice the guest when it thinks it's time for guest to announce the link
>> presnece. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt
>> and woule send gratuitous packets through netif_notify_peers() and ack the
>> notification through ctrl vq.
>>
>> We need to make sure the atomicy of read and ack in guest otherwise we may ack
>> more times than being notified. This is done through handling the whole config
>> change interrupt in an non-reentrant workqueue.
>>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks everyone.
prev parent reply other threads:[~2012-04-15 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 6:43 [net-next V7 PATCH] virtio-net: send gratuitous packets when needed Jason Wang
2012-04-13 17:38 ` David Miller
2012-04-15 7:12 ` Michael S. Tsirkin
2012-04-15 7:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120415.032003.138761548777211783.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).