From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [vmw_vmci RFC 01/11] Apply VMCI context code Date: Wed, 16 May 2012 10:01:21 -0700 Message-ID: <20120516100121.3be6d0ca@nehalam.linuxnetplumber.net> References: <1337094428-20453-1-git-send-email-astiegmann@vmware.com> <1337094428-20453-2-git-send-email-astiegmann@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1337094428-20453-2-git-send-email-astiegmann@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Andrew Stiegmann (stieg)" Cc: acking@vmware.com, dtor@vmware.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, dsouders@vmware.com, akpm@linux-foundation.org, cschamp@vmware.com List-Id: virtualization@lists.linuxfoundation.org On Tue, 15 May 2012 08:06:58 -0700 "Andrew Stiegmann (stieg)" wrote: > Context code maintains state for vmci and allows the driver > to communicate with multiple VMs. > > Signed-off-by: Andrew Stiegmann (stieg) Running checkpatch reveals the usual noise, and the following that should be addressed. ERROR: do not use C99 // comments #272: FILE: drivers/misc/vmw_vmci/vmci_context.c:183: +static bool ctx_exists_locked(uint32_t cid) // IN ERROR: "foo * bar" should be "foo *bar" #304: FILE: drivers/misc/vmw_vmci/vmci_context.c:215: + uid_t * user, struct vmci_ctx **outContext) I don't mind the C99 style comments, but the // IN convention is pretty useless and should be removed.