From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, shemminger@vyatta.com
Subject: Re: [PATCH] virtio-net: fix a race on 32bit arches
Date: Sun, 10 Jun 2012 20:23:41 -0700 (PDT) [thread overview]
Message-ID: <20120610.202341.2146277133562218686.davem@davemloft.net> (raw)
In-Reply-To: <20120610102512.GB6793@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Sun, 10 Jun 2012 13:25:12 +0300
> On Wed, Jun 06, 2012 at 10:35:24AM +0200, Eric Dumazet wrote:
>> From: Eric Dumazet <edumazet@google.com>
>>
>> commit 3fa2a1df909 (virtio-net: per cpu 64 bit stats (v2)) added a race
>> on 32bit arches.
>>
>> We must use separate syncp for rx and tx path as they can be run at the
>> same time on different cpus. Thus one sequence increment can be lost and
>> readers spin forever.
>>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Cc: Stephen Hemminger <shemminger@vyatta.com>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Cc: Jason Wang <jasowang@redhat.com>
>
> I'm still thinking about moving tx to take a xmit lock long term,
> meanwhile this fix appears appropriate for 3.5.
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> Dave, can you pick this up pls?
Done, thanks.
prev parent reply other threads:[~2012-06-11 3:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 8:35 [PATCH] virtio-net: fix a race on 32bit arches Eric Dumazet
2012-06-06 8:45 ` Eric Dumazet
2012-06-06 9:37 ` Jason Wang
2012-06-06 11:13 ` Michael S. Tsirkin
2012-06-06 13:10 ` Eric Dumazet
2012-06-06 14:49 ` Michael S. Tsirkin
2012-06-06 15:14 ` Stephen Hemminger
2012-06-06 15:19 ` Eric Dumazet
2012-06-06 16:17 ` Michael S. Tsirkin
2012-06-06 17:13 ` Eric Dumazet
[not found] ` <1339002782.26966.22.camel@edumazet-glaptop>
2012-06-06 18:43 ` Michael S. Tsirkin
2012-06-06 20:06 ` Eric Dumazet
2012-06-06 20:19 ` Michael S. Tsirkin
2012-06-06 16:57 ` Michael S. Tsirkin
2012-06-06 20:00 ` Eric Dumazet
[not found] ` <20120606081432.6b602065@nehalam.linuxnetplumber.net>
2012-06-06 18:51 ` Michael S. Tsirkin
2012-06-06 19:54 ` Eric Dumazet
[not found] ` <1339012441.26966.48.camel@edumazet-glaptop>
2012-06-06 19:58 ` Michael S. Tsirkin
2012-06-06 20:08 ` Eric Dumazet
2012-06-06 20:16 ` Michael S. Tsirkin
2012-06-06 20:24 ` Eric Dumazet
2012-06-06 20:38 ` Eric Dumazet
2012-06-06 20:35 ` Ben Hutchings
2012-06-06 20:43 ` Michael S. Tsirkin
2012-06-06 20:19 ` Ben Hutchings
[not found] ` <1339013979.2836.52.camel@bwh-desktop.uk.solarflarecom.com>
2012-06-06 20:25 ` Eric Dumazet
2012-06-10 6:36 ` Rusty Russell
2012-06-10 7:03 ` Michael S. Tsirkin
2012-06-10 10:21 ` Eric Dumazet
2012-06-10 10:22 ` Michael S. Tsirkin
2012-06-10 10:25 ` Michael S. Tsirkin
2012-06-11 3:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610.202341.2146277133562218686.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).