virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Asias He <asias@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Tejun Heo <tj@kernel.org>, Shaohua Li <shli@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V5 3/4] virtio-blk: Add bio-based IO path for virtio-blk
Date: Fri, 3 Aug 2012 01:28:14 +0300	[thread overview]
Message-ID: <20120802222814.GA5854@redhat.com> (raw)
In-Reply-To: <1343888757-25723-4-git-send-email-asias@redhat.com>

On Thu, Aug 02, 2012 at 02:25:55PM +0800, Asias He wrote:
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index c0bbeb4..95cfeed 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -14,6 +14,9 @@
>  
>  #define PART_BITS 4
>  
> +static bool use_bio;
> +module_param(use_bio, bool, S_IRUGO);
> +
>  static int major;
>  static DEFINE_IDA(vd_index_ida);
>  

OK, but eventually, you plan to make this use a feature bit, yes?

  reply	other threads:[~2012-08-02 22:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02  6:25 [PATCH V5 0/4] Improve virtio-blk performance Asias He
2012-08-02  6:25 ` [PATCH V5 1/4] block: Introduce __blk_segment_map_sg() helper Asias He
2012-08-02  6:25 ` [PATCH V5 2/4] block: Add blk_bio_map_sg() helper Asias He
2012-08-02  6:25 ` [PATCH V5 3/4] virtio-blk: Add bio-based IO path for virtio-blk Asias He
2012-08-02 22:28   ` Michael S. Tsirkin [this message]
2012-08-03  7:11     ` Asias He
2012-08-02  6:25 ` [PATCH V5 4/4] virtio-blk: Add REQ_FLUSH and REQ_FUA support to bio path Asias He
2012-08-02  6:27   ` Christoph Hellwig
2012-08-02  6:43     ` Asias He
2012-08-06 15:17       ` Christoph Hellwig
2012-08-07  8:50         ` Asias He
2012-08-02 21:40 ` [PATCH V5 0/4] Improve virtio-blk performance Jens Axboe
2012-08-03  7:08   ` Asias He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120802222814.GA5854@redhat.com \
    --to=mst@redhat.com \
    --cc=asias@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@kernel.org \
    --cc=tj@kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).