From: Rafael Aquini <aquini@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rafael Aquini <aquini@linux.com>
Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages
Date: Fri, 3 Aug 2012 08:13:09 -0300 [thread overview]
Message-ID: <20120803111309.GA1848@t510.redhat.com> (raw)
In-Reply-To: <5019975B.6010708@redhat.com>
On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote:
> On 07/23/2012 02:19 PM, Rafael Aquini wrote:
>
> >In a glance, I believe this whole dance you're suggesting might just be too much
> >of an overcomplication, and the best approach would be simply teaching the
> >hotplug bits about the ballooned corner case just like it's being done to
> >compaction/migration. However, I'll look at it carefully before making any other
> >adjustments/propositions over here.
>
> Compaction and hotplug do essentially the same thing
> here: "collect all the movable pages from a page block,
> and move them elsewhere".
>
> Whether or not it is easier for them to share code, or
> to duplicate a few lines of code, is something that can
> be looked into later.
I'm 100% in agreement with your thoughts here.
next prev parent reply other threads:[~2012-08-03 11:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1342485774.git.aquini@redhat.com>
2012-07-17 16:50 ` [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-07-17 16:50 ` [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-07-17 16:50 ` [PATCH v4 3/3] mm: add vm event counters for balloon pages compaction Rafael Aquini
[not found] ` <49f828a9331c9b729fcf77226006921ec5bc52fa.1342485774.git.aquini@redhat.com>
2012-07-18 5:48 ` [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages Minchan Kim
2012-07-18 22:46 ` Andrew Morton
2012-07-18 23:07 ` Rafael Aquini
[not found] ` <20120718230706.GB2313@t510.redhat.com>
2012-07-18 23:12 ` Andrew Morton
2012-07-19 1:00 ` Rafael Aquini
[not found] ` <20120719010047.GD2313@t510.redhat.com>
2012-07-19 1:29 ` Andrew Morton
[not found] ` <20120718182944.24f59012.akpm@linux-foundation.org>
2012-07-19 12:32 ` Rafael Aquini
[not found] ` <20120718054824.GA32341@bbox>
2012-07-20 19:48 ` Rafael Aquini
2012-07-23 2:33 ` Minchan Kim
[not found] ` <20120723023332.GA6832@bbox>
2012-07-23 2:35 ` Minchan Kim
2012-07-23 18:19 ` Rafael Aquini
2012-08-01 20:53 ` Rik van Riel
[not found] ` <5019975B.6010708@redhat.com>
2012-08-03 11:13 ` Rafael Aquini [this message]
2012-08-01 20:51 ` Rik van Riel
2012-08-03 12:26 ` Rafael Aquini
[not found] ` <050e06731e0489867ed804387509e36d072507ec.1342485774.git.aquini@redhat.com>
2012-07-18 22:49 ` [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages Andrew Morton
2012-07-18 23:16 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803111309.GA1848@t510.redhat.com \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=aquini@linux.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mst@redhat.com \
--cc=riel@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).