From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rafael Aquini Subject: Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages Date: Thu, 9 Aug 2012 12:12:19 -0300 Message-ID: <20120809151218.GB2719@t510.redhat.com> References: <20120809090019.GB10288@csn.ul.ie> <20120809144835.GA2719@t510.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120809144835.GA2719@t510.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Mel Gorman Cc: Rik van Riel , Konrad Rzeszutek Wilk , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Andi Kleen , Minchan Kim , Andrew Morton List-Id: virtualization@lists.linuxfoundation.org On Thu, Aug 09, 2012 at 11:48:36AM -0300, Rafael Aquini wrote: > Sure! > what do you think of: > > +/* putback_lru_page() counterpart for a ballooned page */ > +void putback_balloon_page(struct page *page) > +{ > + lock_page(page); > + if (!WARN_ON(!movable_balloon_page(page))) { > + __putback_balloon_page(page); > + put_page(page); > + } > + unlock_page(page); > +} > Or perhaps +/* putback_lru_page() counterpart for a ballooned page */ +void putback_balloon_page(struct page *page) +{ + if (!WARN_ON(!movable_balloon_page(page))) { + lock_page(page); + __putback_balloon_page(page); + put_page(page); + unlock_page(page); + } +}