From: Mel Gorman <mel@csn.ul.ie>
To: Rafael Aquini <aquini@redhat.com>
Cc: Rik van Riel <riel@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Andi Kleen <andi@firstfloor.org>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages
Date: Wed, 15 Aug 2012 10:05:28 +0100 [thread overview]
Message-ID: <20120815090528.GH4052@csn.ul.ie> (raw)
In-Reply-To: <20120814201113.GE22133@t510.redhat.com>
On Tue, Aug 14, 2012 at 05:11:13PM -0300, Rafael Aquini wrote:
> On Tue, Aug 14, 2012 at 10:51:39PM +0300, Michael S. Tsirkin wrote:
> > What I think you should do is use rcu for access.
> > And here sync rcu before freeing.
> > Maybe an overkill but at least a documented synchronization
> > primitive, and it is very light weight.
> >
>
> I liked your suggestion on barriers, as well.
>
I have not thought about this as deeply as I shouold but is simply rechecking
the mapping under the pages_lock to make sure the page is still a balloon
page an option? i.e. use pages_lock to stabilise page->mapping.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2012-08-15 9:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1344619987.git.aquini@redhat.com>
2012-08-10 17:55 ` [PATCH v7 1/4] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-08-12 23:14 ` Minchan Kim
2012-08-13 8:26 ` Michael S. Tsirkin
[not found] ` <20120813082619.GE14081@redhat.com>
2012-08-14 17:44 ` Rafael Aquini
[not found] ` <20120814174404.GA13338@t510.redhat.com>
2012-08-14 19:35 ` Michael S. Tsirkin
2012-08-14 19:48 ` Michael S. Tsirkin
2012-08-14 20:00 ` Rafael Aquini
[not found] ` <20120814194837.GA28863@redhat.com>
2012-08-14 20:03 ` Rafael Aquini
[not found] ` <20120814200043.GB22133@t510.redhat.com>
2012-08-14 20:23 ` Michael S. Tsirkin
2012-08-15 8:52 ` Mel Gorman
2012-08-14 19:52 ` Michael S. Tsirkin
2012-08-10 17:55 ` [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-08-10 17:55 ` [PATCH v7 3/4] mm: introduce putback_movable_pages() Rafael Aquini
2012-08-10 17:55 ` [PATCH v7 4/4] mm: add vm event counters for balloon pages compaction Rafael Aquini
[not found] ` <9147e5cccc4bb2d3f2e5f155e640148eb5365af5.1344619987.git.aquini@redhat.com>
2012-08-12 23:26 ` [PATCH v7 3/4] mm: introduce putback_movable_pages() Minchan Kim
[not found] ` <f19b63dfa026fe2f8f11ec017771161775744781.1344619987.git.aquini@redhat.com>
2012-08-13 8:41 ` [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages Michael S. Tsirkin
[not found] ` <20120813084123.GF14081@redhat.com>
2012-08-13 23:59 ` Rusty Russell
[not found] ` <87lihis5qi.fsf@rustcorp.com.au>
2012-08-14 8:33 ` Michael S. Tsirkin
[not found] ` <20120814083320.GA3597@redhat.com>
2012-08-14 18:44 ` Rafael Aquini
[not found] ` <20120814184409.GC13338@t510.redhat.com>
2012-08-14 19:31 ` Michael S. Tsirkin
[not found] ` <20120814193109.GA28840@redhat.com>
2012-08-15 12:34 ` Rafael Aquini
[not found] ` <20120815123457.GA2175@t510.redhat.com>
2012-08-15 14:40 ` Michael S. Tsirkin
2012-08-20 2:29 ` Rusty Russell
[not found] ` <87fw7i5ma0.fsf@rustcorp.com.au>
2012-08-20 5:12 ` Michael S. Tsirkin
2012-08-15 3:13 ` Rusty Russell
2012-08-14 18:22 ` Rafael Aquini
[not found] ` <20120814182244.GB13338@t510.redhat.com>
2012-08-14 19:51 ` Michael S. Tsirkin
[not found] ` <20120814195139.GA28870@redhat.com>
2012-08-14 19:59 ` Michael S. Tsirkin
[not found] ` <20120814195916.GC28870@redhat.com>
2012-08-14 20:08 ` Rafael Aquini
[not found] ` <20120814200830.GD22133@t510.redhat.com>
2012-08-14 20:24 ` Michael S. Tsirkin
[not found] ` <20120814202401.GB28990@redhat.com>
2012-08-14 20:29 ` Rafael Aquini
[not found] ` <20120814202949.GF22133@t510.redhat.com>
2012-08-14 20:49 ` Michael S. Tsirkin
[not found] ` <20120814204906.GD28990@redhat.com>
2012-08-14 20:54 ` Michael S. Tsirkin
[not found] ` <20120814205426.GA29162@redhat.com>
2012-08-14 20:56 ` Rik van Riel
[not found] ` <502ABB9B.90108@redhat.com>
2012-08-14 21:38 ` Michael S. Tsirkin
[not found] ` <20120814213832.GA29180@redhat.com>
2012-08-15 15:30 ` Rik van Riel
2012-08-14 21:34 ` Rafael Aquini
[not found] ` <20120814213412.GG22133@t510.redhat.com>
2012-08-14 22:48 ` Michael S. Tsirkin
2012-08-14 20:11 ` Rafael Aquini
2012-08-14 20:31 ` Michael S. Tsirkin
2012-08-15 9:05 ` Mel Gorman [this message]
2012-08-15 9:25 ` Michael S. Tsirkin
[not found] ` <20120815092528.GA29214@redhat.com>
2012-08-15 9:48 ` Mel Gorman
[not found] ` <20120815094839.GJ4052@csn.ul.ie>
2012-08-15 10:01 ` Michael S. Tsirkin
[not found] ` <20120815100108.GA1999@redhat.com>
2012-08-15 11:16 ` Mel Gorman
[not found] ` <20120815111651.GL4052@csn.ul.ie>
2012-08-15 11:28 ` Michael S. Tsirkin
2012-08-21 5:31 ` Rusty Russell
[not found] ` <87mx1o3j5y.fsf@rustcorp.com.au>
2012-08-22 0:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815090528.GH4052@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=aquini@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mst@redhat.com \
--cc=riel@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).