From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH V2 00/18] drivers: hv: kvp Date: Thu, 16 Aug 2012 13:55:06 -0700 Message-ID: <20120816205506.GA16940@kroah.com> References: <1344877584-21738-1-git-send-email-kys@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1344877584-21738-1-git-send-email-kys@microsoft.com> Sender: linux-kernel-owner@vger.kernel.org To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, olaf@aepfle.de, apw@canonical.com, ben@decadent.org.uk List-Id: virtualization@lists.linuxfoundation.org On Mon, Aug 13, 2012 at 10:06:24AM -0700, K. Y. Srinivasan wrote: > This patchset expands the KVP (Key Value Pair) functionality to > implement the mechanism to GET/SET IP addresses in the guest. This > functionality is used in Windows Server 2012 to implement VM > replication functionality. The way IP configuration information > is managed is distro specific. Based on the feedback I have gotten > from Olaf, Greg, Steve, Ben and Mairus, I have chosen to seperate > distro specific code from this patch-set. Most of the GET operation > can be implemented in a way that is completely distro independent and > I have implemented that as such and is included in this patch-set. > Some of the attributes that can only be fetched in a distro > dependent way as well the mechanism for configuring an interface > (the SET operation) that is clearly distro specific is to be > implemented via external scripts that will be invoked via the KVP > code. We define here the interface to these scripts. > > Adding support for IP injection resulted in some changes to the > protocol between the user level daemon and the kernel driver. > These changes have been implemented in way that would retain > compatibility with older daemons. I would like to thank Olaf and > Greg for pointing out the compatibility issue. > > This version of the patch set addresses all of the comments that I > have received to date from Olaf, Ben and others. Specifically, I have > cleanedup all of the string manipulation code. Furthermore, I have also > simplified the format of the interface configuration file that is > generated by the KVP daemon and gotten rid of some constant strings that > may not be relevant on all distros. I would like to thank Olaf and Ben > for their detailed review. I've applied some of these, care to resend the rest, with the change I pointed out, and get the reviewed-by: lines correct. thanks, greg k-h