From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio: Don't access device data after unregistration.
Date: Mon, 3 Sep 2012 17:14:45 +0300
Message-ID: <20120903141445.GA5054@redhat.com>
References: <1346680242-5717-1-git-send-email-sjur.brandeland@stericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <virtualization-bounces@lists.linux-foundation.org>
Content-Disposition: inline
In-Reply-To: <1346680242-5717-1-git-send-email-sjur.brandeland@stericsson.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
To: sjur.brandeland@stericsson.com
Cc: Sjur =?iso-8859-1?Q?Br=E6ndeland?= <sjurbren@gmail.com>, "Guzman Lugo,
	Fernadndo" <fernando.lugo@ti.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
List-Id: virtualization@lists.linuxfoundation.org

On Mon, Sep 03, 2012 at 03:50:42PM +0200, sjur.brandeland@stericsson.com wr=
ote:
> From: Sjur Br=E6ndeland <sjur.brandeland@stericsson.com>
> =

> Fix panic in virtio.c when CONFIG_DEBUG_SLAB is set.

What's the root cause of the panic?


> Use device_del() and put_device() instead of
> device_unregister(), and access device data before
> calling put_device().

Why does this help? Does device_unregister free the
device so dev->index access crashes?
If yes virtio_pci_remove will crash too
as it accesses the device after the
call to unregister_virtio_device so the
fix won't be effective.

> Signed-off-by: Sjur Br=E6ndeland <sjur.brandeland@stericsson.com>
> cc: Guzman Lugo, Fernadndo <fernando.lugo@ti.com>
> cc: Michael S. Tsirkin <mst@redhat.com>
> cc: virtualization@lists.linux-foundation.org
> cc: Ohad Ben-Cohen <ohad@wizery.com>
> ---
>  drivers/virtio/virtio.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> =

> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index c3b3f7f..71eacd1 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -225,8 +225,9 @@ EXPORT_SYMBOL_GPL(register_virtio_device);
>  =

>  void unregister_virtio_device(struct virtio_device *dev)
>  {
> -	device_unregister(&dev->dev);
> +	device_del(&dev->dev);
>  	ida_simple_remove(&virtio_index_ida, dev->index);
> +	put_device(&dev->dev);
>  }
>  EXPORT_SYMBOL_GPL(unregister_virtio_device);
>  =

> -- =

> 1.7.5.4