From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation Date: Tue, 4 Sep 2012 21:55:41 +0300 Message-ID: <20120904185541.GB3602@redhat.com> References: <1346680277-5887-1-git-send-email-sjur.brandeland@stericsson.com> <20120903143018.GA5353@redhat.com> <20120903202737.GD6181@redhat.com> <20120904135022.GI9805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Sjur =?iso-8859-1?Q?Br=E6ndeland?= Cc: Linus Walleij , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Amit Shah List-Id: virtualization@lists.linuxfoundation.org On Tue, Sep 04, 2012 at 06:58:47PM +0200, Sjur Br=E6ndeland wrote: > Hi Michael, > = > > Exactly. Though if we just fail load it will be much less code. > > > > Generally, using a feature bit for this is a bit of a problem though: > > normally driver is expected to be able to simply ignore > > a feature bit. In this case driver is required to > > do something so a feature bit is not a good fit. > > I am not sure what the right thing to do is. > = > I see - so in order to avoid the binding between driver and device > there are two options I guess. Either make virtio_dev_match() or > virtcons_probe() fail. Neither of them seems like the obvious choice. > = > Maybe adding a check for VIRTIO_CONSOLE_F_DMA_MEM match > between device and driver in virtcons_probe() is the lesser evil? > = > Regards, > Sjur A simplest thing to do is change dev id. rusty? -- = MST