From: Amit Shah <amit.shah@redhat.com>
To: sjur.brandeland@stericsson.com
Cc: sjurbren@stericsson.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 3/3] virtio_console: Don't initialize buffers to zero
Date: Mon, 1 Oct 2012 13:54:17 +0530 [thread overview]
Message-ID: <20121001082417.GC9810@amit.redhat.com> (raw)
In-Reply-To: <1348580837-10919-4-git-send-email-sjur.brandeland@stericsson.com>
On (Tue) 25 Sep 2012 [15:47:17], sjur.brandeland@stericsson.com wrote:
> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
>
> Skip initializing the receive buffers.
This tells 'what', but not 'why'. Please add some more description.
For the generic virtio ports case, at least, my original thinking was
to not send random guest data to the host device. However, we don't
have any device isolation in the host yet, and doing that will be
expensive, so it's not going to be done in the near future.. this can
be safely skipped.
Also, please make this patch 1/3, so we don't end up doing
kzalloc->kmalloc+memset->kmalloc
Thanks,
Amit
next prev parent reply other threads:[~2012-10-01 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 13:47 [PATCHv6 0/3] virtio_console: Add rproc_serial device sjur.brandeland
2012-09-25 13:47 ` [PATCH 1/3] virtio_console:Merge struct buffer_token into struct port_buffer sjur.brandeland
2012-09-25 13:47 ` [PATCHv5 2/3] virtio_console: Add support for remoteproc serial sjur.brandeland
2012-09-26 23:52 ` Rusty Russell
2012-10-01 9:52 ` Amit Shah
2012-09-25 13:47 ` [PATCH 3/3] virtio_console: Don't initialize buffers to zero sjur.brandeland
2012-10-01 8:24 ` Amit Shah [this message]
[not found] ` <1348580837-10919-2-git-send-email-sjur.brandeland@stericsson.com>
2012-09-26 2:44 ` [PATCH 1/3] virtio_console:Merge struct buffer_token into struct port_buffer Masami Hiramatsu
2012-09-26 7:48 ` Sjur BRENDELAND
2012-09-26 9:40 ` Masami Hiramatsu
2012-09-26 23:42 ` Rusty Russell
2012-10-01 9:39 ` Amit Shah
2012-10-01 9:35 ` Amit Shah
2012-09-28 12:48 ` [PATCHv6 0/3] virtio_console: Add rproc_serial device Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001082417.GC9810@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
--cc=sjurbren@stericsson.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).