From: Amit Shah <amit.shah@redhat.com>
To: sjur.brandeland@stericsson.com
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCHv7 0/4] virtio_console: Add rproc_serial driver
Date: Mon, 22 Oct 2012 18:30:52 +0530 [thread overview]
Message-ID: <20121022130052.GG25057@amit.redhat.com> (raw)
In-Reply-To: <1350287856-5284-1-git-send-email-sjur.brandeland@stericsson.com>
Hello Sjur,
On (Mon) 15 Oct 2012 [09:57:32], sjur.brandeland@stericsson.com wrote:
> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
>
> This patch-set introduces a new virtio type "rproc_serial" for communicating
> with remote processors over shared memory. The driver depends on the
> the remoteproc framework. As preparation for introducing "rproc_serial"
> I've done a refactoring of the transmit buffer handling.
>
> This patch-set is a rework of the patch-set from Sept 25th, hopefully all
> review comments has been addressed.
>
> The fist patch is a bugfix and migth be applicable for 3.7.
Looks good,
Acked-by: Amit Shah <amit.shah@redhat.com>
include/linux/virtio_ids.h has moved to include/uapi/linux/. Last
patch has to be re-spun for that.
Otherwise, I just checked if comments from the previous submission
were addressed. The virtio-console test suite passes fine, so I
didn't really go through everything again.
Thanks,
Amit
next prev parent reply other threads:[~2012-10-22 13:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 7:57 [PATCHv7 0/4] virtio_console: Add rproc_serial driver sjur.brandeland
2012-10-15 7:57 ` [PATCHv7 1/4] virtio_console: Free buffer if splice fails sjur.brandeland
2012-10-15 7:57 ` [PATCHv7 2/4] virtio_console: Use kmalloc instead of kzalloc sjur.brandeland
2012-10-23 1:36 ` Rusty Russell
2012-10-15 7:57 ` [PATCHv7 3/4] virtio_console: Merge struct buffer_token into struct port_buffer sjur.brandeland
2012-10-23 0:19 ` Rusty Russell
2012-10-15 7:57 ` [PATCHv7 4/4] virtio_console: Add support for remoteproc serial sjur.brandeland
2012-10-23 1:47 ` Rusty Russell
[not found] ` <878vayhsca.fsf@rustcorp.com.au>
2012-10-28 21:58 ` Sjur Brændeland
2012-11-01 7:39 ` Amit Shah
[not found] ` <20121101073951.GA17012@amit.redhat.com>
2012-11-01 23:22 ` Rusty Russell
2012-11-02 10:20 ` Amit Shah
2012-11-02 10:44 ` Sjur BRENDELAND
2012-11-07 14:22 ` sjur.brandeland
2012-11-07 13:43 ` [PATCH resend] virtio_console: Free buffers from out-queue upon close sjur.brandeland
2012-11-07 23:58 ` Rusty Russell
[not found] ` <87sj8l2cea.fsf@rustcorp.com.au>
2012-11-08 8:59 ` Amit Shah
2012-11-08 9:25 ` Sjur Brændeland
2012-10-22 13:00 ` Amit Shah [this message]
[not found] ` <1350287856-5284-2-git-send-email-sjur.brandeland@stericsson.com>
2012-10-23 0:12 ` [PATCHv7 1/4] virtio_console: Free buffer if splice fails Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022130052.GG25057@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mst@redhat.com \
--cc=sjur.brandeland@stericsson.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).