From: Greg KH <gregkh@linuxfoundation.org>
To: Andy King <acking@vmware.com>
Cc: pv-drivers@vmware.com, vm-crosstalk@vmware.com,
linux-kernel@vger.kernel.org,
George Zhang <georgezhang@vmware.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.
Date: Thu, 25 Oct 2012 13:31:48 -0700 [thread overview]
Message-ID: <20121025203148.GA28096@kroah.com> (raw)
In-Reply-To: <574849395.2604157.1351196160882.JavaMail.root@vmware.com>
On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote:
> Hi Greg,
>
> > > +EXPORT_SYMBOL(vmci_device_get);
> >
> > EXPORT_SYMBOL_GPL() for this, and all other exports?
>
> We'd prefer to leave them as vanilla exports. While we're committed
> to open-sourcing everything, including our non-upstreamed drivers,
> we don't really have a strong opinion regarding consuming our exports
> in closed-source (general GPL issues aside).
You can't just say "general GPL issues aside". Honestly, given your
company's prior actions in regards to Linux kernel drivers and the
licenses of them, I don't trust them at all. To help gain that trust
back, marking the exports in this manner will be a great improvement.
To insist otherwise is to only reinforce my doubts, and reduce my
wanting to even review or accept this code at all. Sorry about that.
> > And it seems that you have a bunch of "unused" parameters for this,
> > and other public functions. Please just remove them entirely.
>
> Will do.
>
> Also, regarding that particular public function, it seems to have slipped
> through the cracks. It's an artifact of the API being cross-platform
> prior to upstreaming. On Linux, it makes no sense whatsoever, so we'll
> just yank it completely.
What other calls can be removed? Did you run sparse on all of these
files to ensure that things are "clean" with regards to static functions
and the like?
thanks,
greg k-h
next prev parent reply other threads:[~2012-10-25 20:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 0:27 [PATCH 00/10] VMCI for Linux upstreaming George Zhang
2012-10-16 0:28 ` [PATCH 01/10] VMCI: context implementation George Zhang
2012-10-16 0:28 ` [PATCH 02/10] VMCI: datagram implementation George Zhang
2012-10-16 0:28 ` [PATCH 03/10] VMCI: doorbell implementation George Zhang
2012-10-16 0:28 ` [PATCH 04/10] VMCI: device driver implementaton George Zhang
2012-10-25 19:28 ` Greg KH
2012-10-25 20:16 ` [Pv-drivers] " Andy King
2012-10-25 20:31 ` Greg KH [this message]
2012-10-25 20:43 ` Bhavesh Davda
2012-10-25 21:03 ` Greg KH
2012-10-25 21:15 ` Dmitry Torokhov
2012-10-25 20:45 ` Dmitry Torokhov
2012-10-25 21:04 ` Greg KH
2012-10-25 21:13 ` Dmitry Torokhov
2012-10-25 21:18 ` Bhavesh Davda
2012-10-25 21:08 ` Andy King
2012-10-26 20:02 ` Andy King
2012-10-26 20:11 ` Greg KH
2012-10-16 0:28 ` [PATCH 05/10] VMCI: event handling implementation George Zhang
2012-10-16 0:29 ` [PATCH 06/10] VMCI: handle array implementation George Zhang
2012-10-16 0:29 ` [PATCH 07/10] VMCI: queue pairs implementation George Zhang
2012-10-16 0:29 ` [PATCH 08/10] VMCI: resource object implementation George Zhang
2012-10-16 0:29 ` [PATCH 09/10] VMCI: routing implementation George Zhang
2012-10-16 0:29 ` [PATCH 10/10] VMCI: Some header and config files George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025203148.GA28096@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=acking@vmware.com \
--cc=georgezhang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vm-crosstalk@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).