* [PATCH] virtio-spec: fix thinko in multiport documentation
@ 2012-09-09 11:08 Michael S. Tsirkin
2012-09-09 20:58 ` Amit Shah
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Michael S. Tsirkin @ 2012-09-09 11:08 UTC (permalink / raw)
To: Amit Shah, virtualization
spec numbers ports port0, port 1 etc, then goes on to say
"ports 2 onwards only if MULTIPORT is set".
An obvious thinko, should be port 1 onwards.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
virtio-spec.lyx | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index a713807..d801aa6 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
@@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0).
status open
\begin_layout Plain Layout
-Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
+Ports
+\change_inserted 1986246365 1347188327
+1
+\change_deleted 1986246365 1347188327
+2
+\change_unchanged
+ onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
\end_layout
\end_inset
--
MST
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] virtio-spec: fix thinko in multiport documentation
2012-09-09 11:08 [PATCH] virtio-spec: fix thinko in multiport documentation Michael S. Tsirkin
@ 2012-09-09 20:58 ` Amit Shah
2012-11-12 16:59 ` Michael S. Tsirkin
2012-12-12 8:22 ` Michael S. Tsirkin
2 siblings, 0 replies; 7+ messages in thread
From: Amit Shah @ 2012-09-09 20:58 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtualization
On (Sun) 09 Sep 2012 [14:08:37], Michael S. Tsirkin wrote:
> spec numbers ports port0, port 1 etc, then goes on to say
> "ports 2 onwards only if MULTIPORT is set".
> An obvious thinko, should be port 1 onwards.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] virtio-spec: fix thinko in multiport documentation
2012-09-09 11:08 [PATCH] virtio-spec: fix thinko in multiport documentation Michael S. Tsirkin
2012-09-09 20:58 ` Amit Shah
@ 2012-11-12 16:59 ` Michael S. Tsirkin
2012-12-12 8:22 ` Michael S. Tsirkin
2 siblings, 0 replies; 7+ messages in thread
From: Michael S. Tsirkin @ 2012-11-12 16:59 UTC (permalink / raw)
To: Amit Shah, virtualization
On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote:
> spec numbers ports port0, port 1 etc, then goes on to say
> "ports 2 onwards only if MULTIPORT is set".
> An obvious thinko, should be port 1 onwards.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Ping.
> ---
> virtio-spec.lyx | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/virtio-spec.lyx b/virtio-spec.lyx
> index a713807..d801aa6 100644
> --- a/virtio-spec.lyx
> +++ b/virtio-spec.lyx
> @@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0).
> status open
>
> \begin_layout Plain Layout
> -Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
> +Ports
> +\change_inserted 1986246365 1347188327
> +1
> +\change_deleted 1986246365 1347188327
> +2
> +\change_unchanged
> + onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
> \end_layout
>
> \end_inset
> --
> MST
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] virtio-spec: fix thinko in multiport documentation
2012-09-09 11:08 [PATCH] virtio-spec: fix thinko in multiport documentation Michael S. Tsirkin
2012-09-09 20:58 ` Amit Shah
2012-11-12 16:59 ` Michael S. Tsirkin
@ 2012-12-12 8:22 ` Michael S. Tsirkin
2012-12-12 9:14 ` Amit Shah
2 siblings, 1 reply; 7+ messages in thread
From: Michael S. Tsirkin @ 2012-12-12 8:22 UTC (permalink / raw)
To: Amit Shah, virtualization
On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote:
> spec numbers ports port0, port 1 etc, then goes on to say
> "ports 2 onwards only if MULTIPORT is set".
> An obvious thinko, should be port 1 onwards.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Rusty, Amit, any feedback?
> ---
> virtio-spec.lyx | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/virtio-spec.lyx b/virtio-spec.lyx
> index a713807..d801aa6 100644
> --- a/virtio-spec.lyx
> +++ b/virtio-spec.lyx
> @@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0).
> status open
>
> \begin_layout Plain Layout
> -Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
> +Ports
> +\change_inserted 1986246365 1347188327
> +1
> +\change_deleted 1986246365 1347188327
> +2
> +\change_unchanged
> + onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
> \end_layout
>
> \end_inset
> --
> MST
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] virtio-spec: fix thinko in multiport documentation
2012-12-12 8:22 ` Michael S. Tsirkin
@ 2012-12-12 9:14 ` Amit Shah
2012-12-12 9:23 ` Michael S. Tsirkin
0 siblings, 1 reply; 7+ messages in thread
From: Amit Shah @ 2012-12-12 9:14 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtualization
On (Wed) 12 Dec 2012 [10:22:24], Michael S. Tsirkin wrote:
> On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote:
> > spec numbers ports port0, port 1 etc, then goes on to say
> > "ports 2 onwards only if MULTIPORT is set".
> > An obvious thinko, should be port 1 onwards.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Rusty, Amit, any feedback?
http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980
Amit
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] virtio-spec: fix thinko in multiport documentation
2012-12-12 9:14 ` Amit Shah
@ 2012-12-12 9:23 ` Michael S. Tsirkin
2012-12-14 1:01 ` Rusty Russell
0 siblings, 1 reply; 7+ messages in thread
From: Michael S. Tsirkin @ 2012-12-12 9:23 UTC (permalink / raw)
To: Amit Shah; +Cc: virtualization
On Wed, Dec 12, 2012 at 02:44:20PM +0530, Amit Shah wrote:
> On (Wed) 12 Dec 2012 [10:22:24], Michael S. Tsirkin wrote:
> > On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote:
> > > spec numbers ports port0, port 1 etc, then goes on to say
> > > "ports 2 onwards only if MULTIPORT is set".
> > > An obvious thinko, should be port 1 onwards.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Rusty, Amit, any feedback?
>
> http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980
>
> Amit
Ah you acked.
Rusty can you pick this up please?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] virtio-spec: fix thinko in multiport documentation
2012-12-12 9:23 ` Michael S. Tsirkin
@ 2012-12-14 1:01 ` Rusty Russell
0 siblings, 0 replies; 7+ messages in thread
From: Rusty Russell @ 2012-12-14 1:01 UTC (permalink / raw)
To: Michael S. Tsirkin, Amit Shah; +Cc: virtualization
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Wed, Dec 12, 2012 at 02:44:20PM +0530, Amit Shah wrote:
>> On (Wed) 12 Dec 2012 [10:22:24], Michael S. Tsirkin wrote:
>> > On Sun, Sep 09, 2012 at 02:08:37PM +0300, Michael S. Tsirkin wrote:
>> > > spec numbers ports port0, port 1 etc, then goes on to say
>> > > "ports 2 onwards only if MULTIPORT is set".
>> > > An obvious thinko, should be port 1 onwards.
>> > >
>> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> >
>> > Rusty, Amit, any feedback?
>>
>> http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980
>>
>> Amit
>
> Ah you acked.
> Rusty can you pick this up please?
Thanks, done.
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-12-14 1:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-09 11:08 [PATCH] virtio-spec: fix thinko in multiport documentation Michael S. Tsirkin
2012-09-09 20:58 ` Amit Shah
2012-11-12 16:59 ` Michael S. Tsirkin
2012-12-12 8:22 ` Michael S. Tsirkin
2012-12-12 9:14 ` Amit Shah
2012-12-12 9:23 ` Michael S. Tsirkin
2012-12-14 1:01 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).