From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>, Rafael Aquini <aquini@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [patch] virtio_balloon: unlock on error in fill_balloon()
Date: Tue, 13 Nov 2012 10:43:03 +0300 [thread overview]
Message-ID: <20121113074303.GA13198@elgon.mountain> (raw)
We recently added locking in fill_balloon() but there was one error path
which was missed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed in linux-next.
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index f70151b..1c50e98 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -153,9 +153,10 @@ static void fill_balloon(struct virtio_balloon *vb, size_t num)
/* Didn't get any? Oh well. */
if (vb->num_pfns == 0)
- return;
+ goto unlock;
tell_host(vb, vb->inflate_vq);
+unlock:
mutex_unlock(&vb->balloon_lock);
}
next reply other threads:[~2012-11-13 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 7:43 Dan Carpenter [this message]
2012-11-13 14:28 ` [patch] virtio_balloon: unlock on error in fill_balloon() Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113074303.GA13198@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=aquini@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox