From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
bhutchings@solarflare.com, jwhan@filewood.snu.ac.kr,
shiyer@redhat.com
Subject: Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info
Date: Mon, 3 Dec 2012 13:18:48 +0200 [thread overview]
Message-ID: <20121203111848.GD26167@redhat.com> (raw)
In-Reply-To: <3524590.ZWGua7A8ne@jason-thinkpad-t430s>
On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote:
> > > +
>
> > > + /* Work struct for refilling if we run low on memory. */
>
> > > + struct delayed_work refill;
>
> >
>
> > I can't really see the justificaiton for a refill per queue. Just have
>
> > one work iterate all the queues if it happens, unless it happens often
>
> > (in which case, we need to look harder at this anyway).
>
>
>
> But during this kind of iteration, we may need enable/disable the napi
> regardless of whether the receive queue has lots to be refilled. This may add
> extra latency.
We are running from the timer, so latency is not a concern I think.
--
MST
next prev parent reply other threads:[~2012-12-03 11:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 10:15 [net-next rfc v7 0/3] Multiqueue virtio-net Jason Wang
2012-11-27 10:15 ` [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info Jason Wang
2012-12-03 1:55 ` Rusty Russell
2012-12-03 5:15 ` Jason Wang
2012-12-03 11:18 ` Michael S. Tsirkin [this message]
2012-12-04 9:22 ` Jason Wang
2012-12-04 3:43 ` Rusty Russell
2012-12-04 9:23 ` Jason Wang
2012-11-27 10:15 ` [net-next rfc v7 2/3] virtio_net: multiqueue support Jason Wang
2012-12-02 16:06 ` Michael S. Tsirkin
2012-12-03 2:04 ` Rusty Russell
2012-12-03 6:05 ` Jason Wang
2012-12-03 9:47 ` Michael S. Tsirkin
2012-12-03 10:01 ` Jason Wang
2012-12-03 11:11 ` Michael S. Tsirkin
[not found] ` <20121203111118.GC26167@redhat.com>
2012-12-04 9:24 ` Jason Wang
[not found] ` <20121202160631.GA27761@redhat.com>
2012-12-03 5:47 ` Jason Wang
2012-12-03 10:14 ` Michael S. Tsirkin
[not found] ` <20121203101436.GB23009@redhat.com>
2012-12-03 10:30 ` Jason Wang
2012-12-03 11:00 ` Michael S. Tsirkin
2012-12-04 7:35 ` Michael S. Tsirkin
2012-12-04 9:27 ` Jason Wang
2012-11-27 10:16 ` [net-next rfc v7 3/3] virtio-net: change the number of queues through ethtool Jason Wang
2012-12-02 16:09 ` Michael S. Tsirkin
2012-12-03 6:09 ` Jason Wang
2012-12-03 11:25 ` Michael S. Tsirkin
2012-12-04 0:22 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203111848.GD26167@redhat.com \
--to=mst@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=jasowang@redhat.com \
--cc=jwhan@filewood.snu.ac.kr \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shiyer@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).