From: Dan Carpenter <dan.carpenter@oracle.com>
To: roger.pau@citrix.com
Cc: xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org
Subject: re: xen/blkback: Persistent grant maps for xen blk drivers
Date: Tue, 4 Dec 2012 00:06:17 +0300 [thread overview]
Message-ID: <20121203210617.GA1513@elgon.mountain> (raw)
Hello Roger Pau Monne,
The patch 0a8704a51f38: "xen/blkback: Persistent grant maps for xen
blk drivers" from Oct 24, 2012, leads to the following warning:
drivers/block/xen-blkfront.c:807 blkif_free()
warn: 'persistent_gnt' was already freed.
807 llist_for_each_entry(persistent_gnt, all_gnts, node) {
808 gnttab_end_foreign_access(persistent_gnt->gref, 0, 0UL);
809 __free_page(pfn_to_page(persistent_gnt->pfn));
810 kfree(persistent_gnt);
^^^^^^^^^^^^^^
We dereference this to find the next element in the list. It will work
if you don't have poisoning enabled or if the memory is not used
immediately by another process. In other words, there will be rare
bugs where this causes a hard to debug crash or if you have poisoning
enabled it will have an easy to debug crash.
811 }
regards,
dan carpenter
reply other threads:[~2012-12-03 21:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203210617.GA1513@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=roger.pau@citrix.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox