From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/3] virtio: change to_vp_device to an inlined definition Date: Wed, 5 Dec 2012 13:25:00 +0200 Message-ID: <20121205112500.GB12619@redhat.com> References: <1354691009-25966-1-git-send-email-gaowanlong@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1354691009-25966-1-git-send-email-gaowanlong@cn.fujitsu.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Wanlong Gao Cc: virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Wed, Dec 05, 2012 at 03:03:27PM +0800, Wanlong Gao wrote: > to_vp_device is worth changing to inlined definition. > > Signed-off-by: Wanlong Gao I don't think it's worth it. The oldest gcc I happened to have around is 4.3.3 which is already smart enough to generate identical code before and after the patch. And a function is cleaner. > --- > drivers/virtio/virtio_pci.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c > index e3ecc94..7681fe3 100644 > --- a/drivers/virtio/virtio_pci.c > +++ b/drivers/virtio/virtio_pci.c > @@ -98,11 +98,7 @@ static struct pci_device_id virtio_pci_id_table[] = { > > MODULE_DEVICE_TABLE(pci, virtio_pci_id_table); > > -/* Convert a generic virtio device to our structure */ > -static struct virtio_pci_device *to_vp_device(struct virtio_device *vdev) > -{ > - return container_of(vdev, struct virtio_pci_device, vdev); > -} > +#define to_vp_device(_vdev) container_of(_vdev, struct virtio_pci_device, vdev) > > /* virtio config->get_features() implementation */ > static u32 vp_get_features(struct virtio_device *vdev) > -- > 1.8.0