From: Greg KH <gregkh@linuxfoundation.org>
To: George Zhang <georgezhang@vmware.com>
Cc: pv-drivers@vmware.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 07/12] VMCI: queue pairs implementation.
Date: Tue, 8 Jan 2013 16:15:39 -0800 [thread overview]
Message-ID: <20130109001539.GA24989@kroah.com> (raw)
In-Reply-To: <20130108235444.2698.24076.stgit@promb-2n-dhcp175.eng.vmware.com>
On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote:
> VMCI queue pairs allow for bi-directional ordered communication between host and guests.
You should wrap your commit lines at 72 characters, like git asks you to :)
> +/* Guest device port I/O. */
> +struct PPNSet {
> + u64 num_produce_pages;
> + u64 num_consume_pages;
> + u32 *produce_ppns;
> + u32 *consume_ppns;
> + bool initialized;
> +};
I know this is a private structure to the driver, so it's not that big
of a deal at all, but the naming for this is a bit odd (mixed case.)
Not a show stopper at all, but if you had run checkpatch.pl on it, it
would have warned you about this.
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-09 0:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 23:52 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2013-01-08 23:52 ` [PATCH 01/12] VMCI: context implementation George Zhang
2013-01-08 23:53 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2013-01-08 23:53 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2013-01-08 23:54 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2013-01-08 23:54 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2013-01-08 23:54 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2013-01-08 23:54 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2013-01-09 0:15 ` Greg KH [this message]
2013-01-09 0:28 ` [Pv-drivers] " Dmitry Torokhov
2013-01-09 0:50 ` Greg KH
2013-01-08 23:55 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2013-01-08 23:55 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2013-01-08 23:55 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2013-01-08 23:55 ` [PATCH 11/12] VMCI: host " George Zhang
2013-01-08 23:55 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2013-01-09 0:20 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-11-21 20:31 George Zhang
2012-11-21 20:34 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-07 18:40 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-07 18:42 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-15 23:48 ` Greg KH
2012-11-01 17:28 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-01 17:29 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-10-30 1:03 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-10-30 1:04 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109001539.GA24989@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgezhang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).