From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC PATCH 0/2] make mac programming for virtio net more robust Date: Thu, 10 Jan 2013 17:28:29 +0200 Message-ID: <20130110152829.GG30731@redhat.com> References: <1357829141-25455-1-git-send-email-akong@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1357829141-25455-1-git-send-email-akong@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: akong@redhat.com Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Thu, Jan 10, 2013 at 10:45:39PM +0800, akong@redhat.com wrote: > From: Amos Kong > > Currenly mac is programmed byte by byte. This means that we > have an intermediate step where mac is wrong. > > Second patch introduced a new vq control command to set mac > address in one time. As you mention we could alternatively do it without new commands, simply add a feature bit that says that MACs are in the mac table. This would be a much bigger patch, and I'm fine with either way. Rusty what do you think? > Amos Kong (2): > move virtnet_send_command() above virtnet_set_mac_address() > virtio-net: introduce a new control to set macaddr > > drivers/net/virtio_net.c | 105 ++++++++++++++++++++++------------------ > include/uapi/linux/virtio_net.h | 8 ++- > 2 files changed, 66 insertions(+), 47 deletions(-) > > -- > 1.7.11.7