From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
sjur.brandeland@stericsson.com
Subject: Re: [PATCH] virtio_console: Don't access uninitialized data.
Date: Mon, 4 Feb 2013 12:02:51 +0530 [thread overview]
Message-ID: <20130204063251.GB32509@amit.redhat.com> (raw)
In-Reply-To: <87vca9klwm.fsf@rustcorp.com.au>
On (Mon) 04 Feb 2013 [10:09:05], Rusty Russell wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> > On (Thu) 17 Jan 2013 [13:21:32], sjur.brandeland@stericsson.com wrote:
> >> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
> >>
> >> Don't access uninitialized work-queue when removing device.
> >> The work queue is initialized only if the device multi-queue.
> >> So don't call cancel_work unless this is a multi-queue device.
> >>
> >> This fixes the following panic:
> >
> > [snip]
> >
> >> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
> >
> > Acked-by: Amit Shah <amit.shah@redhat.com>
> >
> >> This fix is intended of v3.8.
> >
> > Should also be CC'ed to stable@
>
> Sorry, I was at linux.conf.au all last week.
>
> I've already sent it to Linus. Sjur said: "This fix is intended of
> v3.8.". If it needs to be in -stable, please tell me and I'll fwd it
> manually.
This can result in a panic when removing the device or module (when
not using multiport). I'd vote for submitting to stable.
Amit
next prev parent reply other threads:[~2013-02-04 6:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 12:21 [PATCH] virtio_console: Don't access uninitialized data sjur.brandeland
2013-01-21 23:20 ` Rusty Russell
2013-01-25 9:08 ` Amit Shah
2013-02-03 23:39 ` Rusty Russell
2013-02-04 6:32 ` Amit Shah [this message]
2013-02-06 0:08 ` Rusty Russell
[not found] ` <871ucul2wr.fsf@rustcorp.com.au>
2013-02-06 1:40 ` Greg KH
2013-02-06 2:14 ` Wanlong Gao
[not found] ` <5111BCA3.4040303@cn.fujitsu.com>
2013-02-06 2:22 ` Greg KH
2013-02-07 1:07 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204063251.GB32509@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=sjur.brandeland@stericsson.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).