From: Amit Shah <amit.shah@redhat.com>
To: "Sjur Brændeland" <sjurbren@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_console: Use virtio device index to generate port name
Date: Mon, 11 Feb 2013 21:24:40 +0530 [thread overview]
Message-ID: <20130211155440.GB8319@amit.redhat.com> (raw)
In-Reply-To: <CAJK669aD7S4kxm3fo401v2ni1LubNAB=96aB1uWsd9NmBKjzQw@mail.gmail.com>
On (Mon) 11 Feb 2013 [14:12:52], Sjur Brændeland wrote:
> On Fri, Jan 25, 2013 at 10:20 AM, Amit Shah <amit.shah@redhat.com> wrote:
>
> > On (Thu) 17 Jan 2013 [13:23:17], sjur.brandeland@stericsson.com wrote:
> > > From: Sjur Brændeland <sjur.brandeland@stericsson.com>
> > >
> > > Use virtio device index for creating unique device port names.
> > > Current index allocation in virtio is based on a monotonically
> > > increasing variable "index". A better handling of this is to
> > > use device index which is allocated by ida.
> >
> > This should be fine. I'm wondering, though, if there's something else
> > you need from the naming scheme (esp. considering the next patch)?
>
> This current patch solves the most critical issue - that the device name
> changes for every modem reboot. This is a show-stopper for me. So it would
> be
> great if this patch could go upstream. The other problem that device name
> is non-deterministic is currently only a theoretical problem as we have
> only one
> remoteproc device.
OK - I've no problem with the patch.
Amit
next prev parent reply other threads:[~2013-02-11 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 12:23 [PATCH] virtio_console: Use virtio device index to generate port name sjur.brandeland
2013-01-21 23:23 ` Rusty Russell
2013-01-25 9:20 ` Amit Shah
2013-02-11 13:12 ` Sjur Brændeland
2013-02-11 15:54 ` Amit Shah [this message]
2013-02-11 15:55 ` Amit Shah
2013-02-12 5:56 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211155440.GB8319@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=sjurbren@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).