From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Sjur Brændeland" <sjurbren@gmail.com>
Cc: Amit Shah <amit.shah@redhat.com>,
Erwan.Yvin@stericsson.com,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio_console: Let unconnected rproc device receive data.
Date: Tue, 12 Feb 2013 12:09:30 +0200 [thread overview]
Message-ID: <20130212100930.GA23359@redhat.com> (raw)
In-Reply-To: <CAJK669Y2=FRDLH9RbyzfVLQaF+wUNoziBzWZA=7mfG7VMmZWBw@mail.gmail.com>
On Tue, Feb 12, 2013 at 11:01:10AM +0100, Sjur Brændeland wrote:
> On Tue, Feb 12, 2013 at 10:42 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> ...
> > > > > How about setting port->guest_connected = true in the init routines
> > > > > instead? Keeps this code path cleaner.
> > > >
> > > > Agree, I'll respin this patch.
> > >
> > > Hm, Rusty has already picked this up.
> >
> > I don't see it in virtio-next. Do you?
>
>
> Yes I do, see:
>
> http://git.kernel.org/?p=linux/kernel/git/rusty/linux.git;a=commitdiff;h=1f8051876a194d7f7fe7834d9853f240d6b4b9ab;hp=226364766f936d249e408de03821468c1bf11dda
>
> Regards,
> Sjur
Right, missed this. In this case better to send an incremental patch I
think, we don't want rebases unless absolutely required.
--
MST
next prev parent reply other threads:[~2013-02-12 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 12:22 [PATCH] virtio_console: Let unconnected rproc device receive data sjur.brandeland
2013-01-21 23:21 ` Rusty Russell
2013-01-25 9:10 ` Amit Shah
2013-01-25 11:24 ` Sjur BRENDELAND
2013-02-12 9:14 ` Sjur Brændeland
2013-02-12 9:26 ` Amit Shah
2013-02-12 9:42 ` Michael S. Tsirkin
2013-02-12 10:01 ` Sjur Brændeland
2013-02-12 10:09 ` Michael S. Tsirkin [this message]
2013-02-18 22:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212100930.GA23359@redhat.com \
--to=mst@redhat.com \
--cc=Erwan.Yvin@stericsson.com \
--cc=amit.shah@redhat.com \
--cc=sjurbren@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).