From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio_console: Let unconnected rproc device receive data. Date: Tue, 12 Feb 2013 12:09:30 +0200 Message-ID: <20130212100930.GA23359@redhat.com> References: <1358425362-4517-1-git-send-email-sjur.brandeland@stericsson.com> <20130125091024.GB30483@amit.redhat.com> <81C3A93C17462B4BBD7E272753C105792458D7DEEF@EXDCVYMBSTM005.EQ1STM.local> <20130212094242.GC22567@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Sjur =?iso-8859-1?Q?Br=E6ndeland?= Cc: Amit Shah , Erwan.Yvin@stericsson.com, "virtualization@lists.linux-foundation.org" List-Id: virtualization@lists.linuxfoundation.org On Tue, Feb 12, 2013 at 11:01:10AM +0100, Sjur Br=E6ndeland wrote: > On Tue, Feb 12, 2013 at 10:42 AM, Michael S. Tsirkin wro= te: > ... > > > > > How about setting port->guest_connected =3D true in the init rout= ines > > > > > instead? Keeps this code path cleaner. > > > > > > > > Agree, I'll respin this patch. > > > > > > Hm, Rusty has already picked this up. > > > > I don't see it in virtio-next. Do you? > = > = > Yes I do, see: > = > http://git.kernel.org/?p=3Dlinux/kernel/git/rusty/linux.git;a=3Dcommitdif= f;h=3D1f8051876a194d7f7fe7834d9853f240d6b4b9ab;hp=3D226364766f936d249e408de= 03821468c1bf11dda > = > Regards, > Sjur Right, missed this. In this case better to send an incremental patch I think, we don't want rebases unless absolutely required. -- = MST