* [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL @ 2013-02-28 21:56 Kees Cook 2013-02-28 22:53 ` Stefano Stabellini 0 siblings, 1 reply; 5+ messages in thread From: Kees Cook @ 2013-02-28 21:56 UTC (permalink / raw) To: linux-kernel Cc: Jeremy Fitzhardinge, xen-devel, Konrad Rzeszutek Wilk, x86, virtualization, Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Mukesh Rathor, Stefano Stabellini The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs. Signed-off-by: Kees Cook <keescook@chromium.org> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: Mukesh Rathor <mukesh.rathor@oracle.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- v2: - drop EXPERIMENTAL from bool and help text too. --- arch/x86/xen/Kconfig | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 93ff4e1..6c5802f 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -52,12 +52,10 @@ config XEN_DEBUG_FS Enabling this option may incur a significant performance overhead. config XEN_X86_PVH - bool "Support for running as a PVH guest (EXPERIMENTAL)" - depends on X86_64 && XEN && EXPERIMENTAL + bool "Support for running as a PVH guest" + depends on X86_64 && XEN default n help This option enables support for running as a PVH guest (PV guest using hardware extensions) under a suitably capable hypervisor. - This option is EXPERIMENTAL because the hypervisor interfaces - which it uses is not yet considered stable therefore backwards and - forwards compatibility is not yet guaranteed. If unsure, say N. + If unsure, say N. -- 1.7.9.5 -- Kees Cook Chrome OS Security ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL 2013-02-28 21:56 [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL Kees Cook @ 2013-02-28 22:53 ` Stefano Stabellini 2013-02-28 23:02 ` Kees Cook 0 siblings, 1 reply; 5+ messages in thread From: Stefano Stabellini @ 2013-02-28 22:53 UTC (permalink / raw) To: Kees Cook Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Mukesh Rathor, Stefano Stabellini On Thu, 28 Feb 2013, Kees Cook wrote: > The CONFIG_EXPERIMENTAL config item has not carried much meaning for a > while now and is almost always enabled by default. As agreed during the > Linux kernel summit, remove it from any "depends on" lines in Kconfigs. > > Signed-off-by: Kees Cook <keescook@chromium.org> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > Cc: Mukesh Rathor <mukesh.rathor@oracle.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > > v2: > - drop EXPERIMENTAL from bool and help text too. > > --- > arch/x86/xen/Kconfig | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > index 93ff4e1..6c5802f 100644 > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -52,12 +52,10 @@ config XEN_DEBUG_FS > Enabling this option may incur a significant performance overhead. > > config XEN_X86_PVH > - bool "Support for running as a PVH guest (EXPERIMENTAL)" > - depends on X86_64 && XEN && EXPERIMENTAL > + bool "Support for running as a PVH guest" > + depends on X86_64 && XEN > default n > help > This option enables support for running as a PVH guest (PV guest > using hardware extensions) under a suitably capable hypervisor. > - This option is EXPERIMENTAL because the hypervisor interfaces > - which it uses is not yet considered stable therefore backwards and > - forwards compatibility is not yet guaranteed. If unsure, say N. > + If unsure, say N. Please do not change the text this way. The fact that CONFIG_EXPERIMENTAL is going away it doesn't change the fact that this feature is experimental. Maybe you want to replace EXPERIMENTAL with experimental, or if experimental has become as taboo word, I am sure you can find a suitable synonym. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL 2013-02-28 22:53 ` Stefano Stabellini @ 2013-02-28 23:02 ` Kees Cook 2013-02-28 23:10 ` Stefano Stabellini 0 siblings, 1 reply; 5+ messages in thread From: Kees Cook @ 2013-02-28 23:02 UTC (permalink / raw) To: Stefano Stabellini Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Mukesh Rathor On Thu, Feb 28, 2013 at 2:53 PM, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote: > On Thu, 28 Feb 2013, Kees Cook wrote: >> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a >> while now and is almost always enabled by default. As agreed during the >> Linux kernel summit, remove it from any "depends on" lines in Kconfigs. >> >> Signed-off-by: Kees Cook <keescook@chromium.org> >> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> >> Cc: Mukesh Rathor <mukesh.rathor@oracle.com> >> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >> --- >> >> v2: >> - drop EXPERIMENTAL from bool and help text too. >> >> --- >> arch/x86/xen/Kconfig | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig >> index 93ff4e1..6c5802f 100644 >> --- a/arch/x86/xen/Kconfig >> +++ b/arch/x86/xen/Kconfig >> @@ -52,12 +52,10 @@ config XEN_DEBUG_FS >> Enabling this option may incur a significant performance overhead. >> >> config XEN_X86_PVH >> - bool "Support for running as a PVH guest (EXPERIMENTAL)" >> - depends on X86_64 && XEN && EXPERIMENTAL >> + bool "Support for running as a PVH guest" >> + depends on X86_64 && XEN >> default n >> help >> This option enables support for running as a PVH guest (PV guest >> using hardware extensions) under a suitably capable hypervisor. >> - This option is EXPERIMENTAL because the hypervisor interfaces >> - which it uses is not yet considered stable therefore backwards and >> - forwards compatibility is not yet guaranteed. If unsure, say N. >> + If unsure, say N. > > Please do not change the text this way. > The fact that CONFIG_EXPERIMENTAL is going away it doesn't change the > fact that this feature is experimental. > Maybe you want to replace EXPERIMENTAL with experimental, or if > experimental has become as taboo word, I am sure you can find a suitable > synonym. Ah, sorry, I misunderstood what was being recommended from the other thread (quoting below...) On Sat, 23 Feb 2013, Konrad Rzeszutek Wilk wrote: > It certainly is unstable right now (which is why it was unstaged from > the v3.9 train). I hope that by v3.10 it won't be - at which > point this patch (and the EXPERIMENTAL) makes sense. Only "depends on EXPERIMENTAL" must go away. Did you want either the bool or help text to go away too? If neither, my original patch should work. If you only want the bool text gone, I can send that version instead. -Kees -- Kees Cook Chrome OS Security ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL 2013-02-28 23:02 ` Kees Cook @ 2013-02-28 23:10 ` Stefano Stabellini 2013-03-01 13:45 ` Konrad Rzeszutek Wilk 0 siblings, 1 reply; 5+ messages in thread From: Stefano Stabellini @ 2013-02-28 23:10 UTC (permalink / raw) To: Kees Cook Cc: Jeremy Fitzhardinge, x86@kernel.org, Konrad Rzeszutek Wilk, Stefano Stabellini, Mukesh Rathor, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar, H. Peter Anvin, Thomas Gleixner, xen-devel@lists.xensource.com On Thu, 28 Feb 2013, Kees Cook wrote: > On Thu, Feb 28, 2013 at 2:53 PM, Stefano Stabellini > <stefano.stabellini@eu.citrix.com> wrote: > > On Thu, 28 Feb 2013, Kees Cook wrote: > >> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a > >> while now and is almost always enabled by default. As agreed during the > >> Linux kernel summit, remove it from any "depends on" lines in Kconfigs. > >> > >> Signed-off-by: Kees Cook <keescook@chromium.org> > >> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > >> Cc: Mukesh Rathor <mukesh.rathor@oracle.com> > >> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > >> --- > >> > >> v2: > >> - drop EXPERIMENTAL from bool and help text too. > >> > >> --- > >> arch/x86/xen/Kconfig | 8 +++----- > >> 1 file changed, 3 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > >> index 93ff4e1..6c5802f 100644 > >> --- a/arch/x86/xen/Kconfig > >> +++ b/arch/x86/xen/Kconfig > >> @@ -52,12 +52,10 @@ config XEN_DEBUG_FS > >> Enabling this option may incur a significant performance overhead. > >> > >> config XEN_X86_PVH > >> - bool "Support for running as a PVH guest (EXPERIMENTAL)" > >> - depends on X86_64 && XEN && EXPERIMENTAL > >> + bool "Support for running as a PVH guest" > >> + depends on X86_64 && XEN > >> default n > >> help > >> This option enables support for running as a PVH guest (PV guest > >> using hardware extensions) under a suitably capable hypervisor. > >> - This option is EXPERIMENTAL because the hypervisor interfaces > >> - which it uses is not yet considered stable therefore backwards and > >> - forwards compatibility is not yet guaranteed. If unsure, say N. > >> + If unsure, say N. > > > > Please do not change the text this way. > > The fact that CONFIG_EXPERIMENTAL is going away it doesn't change the > > fact that this feature is experimental. > > Maybe you want to replace EXPERIMENTAL with experimental, or if > > experimental has become as taboo word, I am sure you can find a suitable > > synonym. > > Ah, sorry, I misunderstood what was being recommended from the other > thread (quoting below...) > > On Sat, 23 Feb 2013, Konrad Rzeszutek Wilk wrote: > > It certainly is unstable right now (which is why it was unstaged from > > the v3.9 train). I hope that by v3.10 it won't be - at which > > point this patch (and the EXPERIMENTAL) makes sense. > > Only "depends on EXPERIMENTAL" must go away. Did you want either the > bool or help text to go away too? If neither, my original patch should > work. If you only want the bool text gone, I can send that version > instead. I think your original patch is good, but I'll let Konrad decide. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL 2013-02-28 23:10 ` Stefano Stabellini @ 2013-03-01 13:45 ` Konrad Rzeszutek Wilk 0 siblings, 0 replies; 5+ messages in thread From: Konrad Rzeszutek Wilk @ 2013-03-01 13:45 UTC (permalink / raw) To: Stefano Stabellini Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com, Kees Cook, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Mukesh Rathor On Thu, Feb 28, 2013 at 11:10:55PM +0000, Stefano Stabellini wrote: > On Thu, 28 Feb 2013, Kees Cook wrote: > > On Thu, Feb 28, 2013 at 2:53 PM, Stefano Stabellini > > <stefano.stabellini@eu.citrix.com> wrote: > > > On Thu, 28 Feb 2013, Kees Cook wrote: > > >> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a > > >> while now and is almost always enabled by default. As agreed during the > > >> Linux kernel summit, remove it from any "depends on" lines in Kconfigs. > > >> > > >> Signed-off-by: Kees Cook <keescook@chromium.org> > > >> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > >> Cc: Mukesh Rathor <mukesh.rathor@oracle.com> > > >> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > >> --- > > >> > > >> v2: > > >> - drop EXPERIMENTAL from bool and help text too. > > >> > > >> --- > > >> arch/x86/xen/Kconfig | 8 +++----- > > >> 1 file changed, 3 insertions(+), 5 deletions(-) > > >> > > >> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > > >> index 93ff4e1..6c5802f 100644 > > >> --- a/arch/x86/xen/Kconfig > > >> +++ b/arch/x86/xen/Kconfig > > >> @@ -52,12 +52,10 @@ config XEN_DEBUG_FS > > >> Enabling this option may incur a significant performance overhead. > > >> > > >> config XEN_X86_PVH > > >> - bool "Support for running as a PVH guest (EXPERIMENTAL)" > > >> - depends on X86_64 && XEN && EXPERIMENTAL > > >> + bool "Support for running as a PVH guest" > > >> + depends on X86_64 && XEN > > >> default n > > >> help > > >> This option enables support for running as a PVH guest (PV guest > > >> using hardware extensions) under a suitably capable hypervisor. > > >> - This option is EXPERIMENTAL because the hypervisor interfaces > > >> - which it uses is not yet considered stable therefore backwards and > > >> - forwards compatibility is not yet guaranteed. If unsure, say N. > > >> + If unsure, say N. > > > > > > Please do not change the text this way. > > > The fact that CONFIG_EXPERIMENTAL is going away it doesn't change the > > > fact that this feature is experimental. > > > Maybe you want to replace EXPERIMENTAL with experimental, or if > > > experimental has become as taboo word, I am sure you can find a suitable > > > synonym. > > > > Ah, sorry, I misunderstood what was being recommended from the other > > thread (quoting below...) > > > > On Sat, 23 Feb 2013, Konrad Rzeszutek Wilk wrote: > > > It certainly is unstable right now (which is why it was unstaged from > > > the v3.9 train). I hope that by v3.10 it won't be - at which > > > point this patch (and the EXPERIMENTAL) makes sense. > > > > Only "depends on EXPERIMENTAL" must go away. Did you want either the > > bool or help text to go away too? If neither, my original patch should > > work. If you only want the bool text gone, I can send that version > > instead. > > I think your original patch is good, but I'll let Konrad decide. By the time PVH is going to Linus it better be stable. So the revised patch is OK with me (fyi, this patch is going in my stable/pvh.v7 which is part of #linux-next). ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-01 13:45 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-02-28 21:56 [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL Kees Cook 2013-02-28 22:53 ` Stefano Stabellini 2013-02-28 23:02 ` Kees Cook 2013-02-28 23:10 ` Stefano Stabellini 2013-03-01 13:45 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).