From: Asias He <asias@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support
Date: Thu, 7 Mar 2013 08:36:10 +0800 [thread overview]
Message-ID: <20130307003609.GC8785@hj.localdomain> (raw)
In-Reply-To: <51377FDB.1080605@redhat.com>
On Wed, Mar 06, 2013 at 06:41:47PM +0100, Paolo Bonzini wrote:
> Il 06/03/2013 02:28, Asias He ha scritto:
> >> > This can queue up quite a bit of memory if the handler thread
> >> > is delayed, no? Can we limit the # of outstanding events?
> >> > Will guest recover from a missed event?
> > Hmm, good point. Will limit the number. The size of 'struct
> > tcm_vhost_evt' is around 20 bytes. So if we limit it to 128, it is ~2.5K
> > of memory.
> >
> > Paolo, if we limit the number of outstanding events and set
> > vs->vs_events_dropped, the guest will recover from a missed event, right?
>
> Yes. At least it should (it doesn't yet).
Ok, thanks.
> Paolo
>
--
Asias
next prev parent reply other threads:[~2013-03-07 0:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1362475027-12018-1-git-send-email-asias@redhat.com>
2013-03-05 9:31 ` [PATCH] tcm_vhost: Add hotplug/hotunplug support Wanlong Gao
2013-03-06 1:29 ` Asias He
2013-03-05 12:11 ` Michael S. Tsirkin
2013-03-05 13:21 ` Paolo Bonzini
2013-03-05 14:34 ` Michael S. Tsirkin
2013-03-05 22:51 ` Nicholas A. Bellinger
2013-03-06 1:40 ` Asias He
[not found] ` <1362523912.7905.208.camel@haakon2.linux-iscsi.org>
2013-03-06 14:28 ` Paolo Bonzini
2013-03-07 0:55 ` Asias He
2013-03-07 22:45 ` Nicholas A. Bellinger
[not found] ` <1362696348.7905.242.camel@haakon2.linux-iscsi.org>
2013-03-08 2:26 ` Asias He
2013-03-06 1:28 ` Asias He
2013-03-06 17:41 ` Paolo Bonzini
2013-03-07 0:36 ` Asias He [this message]
2013-03-05 9:17 Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307003609.GC8785@hj.localdomain \
--to=asias@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox